Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiota Dotnet Mono repo migration #262

Merged
merged 18 commits into from
Jul 8, 2024
Merged

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jul 5, 2024

Fixes #238

In Summary changes include

  • Restructure csproj file to be simpler to eliminate repeated configs (which are now held in Directory.Build.props)
  • Update version stratey to be common accross libs (pulled from Directory.Build.props)
  • Updates CI and release pipelines/scripts
  • Moves sources of other libraries to be held in one project solution (Microsoft.Kiota) as below
 └─Microsoft.Kiota.sln
 └─src
    └─abstractions
    └─authentication
       └─azure
    └─http
       └─httpClient
    └─serialization
       └─json
       └─form
       └─text
       └─multipart
 └─tests
    └─abstractions
    └─authentication
       └─azure
    └─http
       └─httpClient
    └─serialization
       └─json
       └─form
       └─text
       └─multipart

CI/Validation

Notes
To separate concerns, sources are migrated as is. Resolving any issues with the source would ideally be done separately.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good progress, I left a couple of comments to help. Also:

  • dependabot configuration needs to be updated.
  • repo url in csproj needs to be changed to kiota-dotnet (I'll rename the repo after we merge)

src/abstractions/README.md Outdated Show resolved Hide resolved
src/authentication/azure/README.md Outdated Show resolved Hide resolved
src/http/httpClient/README.md Outdated Show resolved Hide resolved
src/serialization/form/README.md Outdated Show resolved Hide resolved
src/serialization/json/README.md Outdated Show resolved Hide resolved
src/serialization/multipart/README.md Outdated Show resolved Hide resolved
src/serialization/text/README.md Outdated Show resolved Hide resolved
@andrueastman andrueastman force-pushed the andrueastman/monoRepoMigration branch from 7083ad8 to fc11a4f Compare July 8, 2024 08:34
@andrueastman
Copy link
Member Author

andrueastman commented Jul 8, 2024

@baywet With regards to the dependabot configs, I notice the config is already set to scan the repository root(this should pick up any csproj files). Any chance you had different thoughts here with regards to updating this?

<!-- Common default project properties for ALL projects-->
<PropertyGroup>
<VersionPrefix>1.9.8</VersionPrefix>
<VersionSuffix>preview</VersionSuffix>
Copy link
Member Author

@andrueastman andrueastman Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The preview suffix is intentional for now to double check the release process end to end without breaking with a production version with regards to sourcelink, signing and all packages getting published. Will empty the value in a separate PR once previews are confirmed to be valid.
Run here already validates proper signing but best to be sure.

@andrueastman andrueastman changed the title [WIP] Kiota Dotnet Mono repo migration Kiota Dotnet Mono repo migration Jul 8, 2024
@andrueastman andrueastman requested a review from baywet July 8, 2024 10:15
@andrueastman andrueastman marked this pull request as ready for review July 8, 2024 10:15
@andrueastman andrueastman requested a review from a team as a code owner July 8, 2024 10:15
.azure-pipelines/ci-build.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/abstractions/Changelog-old.md Show resolved Hide resolved
src/authentication/azure/Changelog-old.md Show resolved Hide resolved
Co-authored-by: Vincent Biret <[email protected]>
Copy link

sonarcloud bot commented Jul 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
70.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@andrueastman andrueastman requested a review from baywet July 8, 2024 13:14
@andrueastman andrueastman merged commit 965b277 into main Jul 8, 2024
10 of 11 checks passed
@andrueastman andrueastman deleted the andrueastman/monoRepoMigration branch July 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Group kiota dotnet repositories
2 participants