-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiota Dotnet Mono repo migration #262
Conversation
Rename solution to Microsoft Kiota.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good progress, I left a couple of comments to help. Also:
- dependabot configuration needs to be updated.
- repo url in csproj needs to be changed to kiota-dotnet (I'll rename the repo after we merge)
7083ad8
to
fc11a4f
Compare
@baywet With regards to the dependabot configs, I notice the config is already set to scan the repository root(this should pick up any csproj files). Any chance you had different thoughts here with regards to updating this? |
<!-- Common default project properties for ALL projects--> | ||
<PropertyGroup> | ||
<VersionPrefix>1.9.8</VersionPrefix> | ||
<VersionSuffix>preview</VersionSuffix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: The preview
suffix is intentional for now to double check the release process end to end without breaking with a production version with regards to sourcelink, signing and all packages getting published. Will empty the value in a separate PR once previews are confirmed to be valid.
Run here already validates proper signing but best to be sure.
Co-authored-by: Vincent Biret <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Fixes #238
In Summary changes include
Directory.Build.props
)Directory.Build.props
)Microsoft.Kiota
) as belowCI/Validation
Notes
To separate concerns, sources are migrated as is. Resolving any issues with the source would ideally be done separately.