Add support to JsonSerializationWriter.WriteNonParsableObjectValue for anonymous objects. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r anonymous objects.
baywet
requested changes
Jul 25, 2024
|
@microsoft-github-policy-service agree company="Civitai" |
There was a problem hiding this comment.
Thanks for the contribution @greg-ww
Any chance you can do the following as well?
- Run
dotnet formatto fix linting errors - Bump the patch version at
kiota-dotnet/Directory.Build.props
Line 4 in 1eca71b
- Add a changelog entry at https://github.com/microsoft/kiota-dotnet/blob/main/CHANGELOG.md
|
Will try to implement this feedback today. |
Improvement to exception messaging.
|
@andrueastman I made the requested modifications, let me know if I missed anything. |
baywet
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.