-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "workaround api failures on loading environments" #3248
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 71db906. The workaround isn't needed. The reported failures was caused by incorrect runbook. Signed-off-by: Konstantin Olshanov <[email protected]>
@olshanov please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree company="Cloud Linux" |
@@ -1683,7 +1683,7 @@ def _parse_detail_errors(self, error: Any) -> List[str]: | |||
def _load_vms( | |||
self, resource_group_name: str, log: Logger | |||
) -> Dict[str, VirtualMachine]: | |||
compute_client = get_compute_client(self) | |||
compute_client = get_compute_client(self, api_version="2020-06-01") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this API version also? @LiliDeng, please have a test, if latest Azure API works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
This reverts commit 71db906.
The workaround isn't needed. The reported failures was caused by incorrect runbook.