Fixed VM Snapshot Extension test failure - Expected <10> to be less than <10>, but was not #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the error is because of repeated retries that were happening because of failures, and since it exceeded 10 retries we see that error. Now we will have to check why were the failures occurring/happening |
LiliDeng
previously approved these changes
Nov 11, 2024
|
@arisettisanjana please fix the CI check error |
LiliDeng
reviewed
Nov 13, 2024
| @@ -265,7 +265,7 @@ def _verify_vmsnapshot_extension( | |||
| else: | |||
| raise e | |||
| time.sleep(1) | |||
| count = count + 1 | |||
| count +=1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test VmSnapsotLinuxBVTExtension.verify_vmsnapshot_extension was failing due AssertionError: [Restore point creation failed.] Expected <10> to be less than <10>, but was not.
For this, have removed redundant count increment from the func _verify_vmsnapshot_extension and now it is passing