Add b4 Tool #3506
Add b4 Tool #3506
Conversation
Add method am to apply patches download by B4
adityagesh
force-pushed
the
aditya/tools_b4
branch
2 times, most recently
from
8baa196
to
aab22a4
Compare
| @@ -201,6 +201,17 @@ def apply( | |||
| ) | |||
| result.assert_exit_code(message=f"failed on applying patches. {result.stdout}") | |||
|
|
|||
| def am(self, cwd: pathlib.PurePath, patch: pathlib.PurePath) -> None: | |||
| result = self.run( | |||
| f"am {patch}", | |||
There was a problem hiding this comment.
does git am depend on b4 package?
There was a problem hiding this comment.
The output of b4 is a .mbx file. You can apply this patch to the repo using git am "filename.mbx"
As per description, git am can be used to apply any email related patch, whereas git apply is for the .patch files
There was a problem hiding this comment.
I didn't see the place which uses b4 tool
There was a problem hiding this comment.
I will be raising that as a separate PR, added that in the description.
I have created a Modifier in Kernel Install transformer that uses b4 to apply patches
There was a problem hiding this comment.
I can add those changes to this PR, if you prefer having it in the same PR
adityagesh
force-pushed
the
aditya/tools_b4
branch
from
aab22a4
to
3876b5d
Compare
| @@ -201,6 +201,17 @@ def apply( | |||
| ) | |||
| result.assert_exit_code(message=f"failed on applying patches. {result.stdout}") | |||
|
|
|||
| def am(self, cwd: pathlib.PurePath, patch: pathlib.PurePath) -> None: | |||
There was a problem hiding this comment.
I see you put arg name as "patch" unlike git apply where it has "patches". Does it not work with multiple patches/mboxes? Can you test once if not tested for the tools/library sake?
There was a problem hiding this comment.
Interesting, I did not notice that.
Though the parameter is named patches, it accepts a Purepath and not list of Purepath.
I will verify the behavior and fix it along with Chi's comment below
There was a problem hiding this comment.
By multiple I meant something like a pattern.
Ref:
| @@ -201,6 +201,17 @@ def apply( | |||
| ) | |||
| result.assert_exit_code(message=f"failed on applying patches. {result.stdout}") | |||
|
|
|||
| def am(self, cwd: pathlib.PurePath, patch: pathlib.PurePath) -> None: | |||
There was a problem hiding this comment.
Change the name to apply_mail. But if it's possible, you can check the file ext, and implement it in apply method.
Add b4 tool to download upstream patches.
Add am method to git in order to apply this patch.
The usage of these will be raised as a separate PR. A new modifier will be added to kernel_installer to modify code using b4.