Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 13, 2026

When virtual tool mode is enabled in VSCode (>128 tools), Copilot groups tools by embedding similarity, causing azureterraformbestpractices to compete with get_azure_bestpractices for selection. This merge eliminates the competition and reduces total tool count.

Changes

  • Added terraform resource type to get_azure_bestpractices:

    • Accepts --resource terraform --action all
    • Returns same content as old azureterraformbestpractices get
    • Validation ensures terraform only supports all action
  • Removed AzureTerraformBestPractices project:

    • Deleted project directory
    • Removed from solution and Program.cs registration
    • Updated test helpers and consolidated tool mappings
  • Updated documentation and references:

    • Command reference docs now show new syntax
    • CHANGELOG notes breaking change
    • VSCode package.json removes old tool from enum
    • IaC best practices reference updated tool name

Migration

# Before
azmcp azureterraformbestpractices get

# After  
azmcp get_azure_bestpractices get --resource terraform --action all

Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • learn.microsoft.com
    • Triggering command: /home/REDACTED/work/mcp/mcp/core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/bin/Debug/net9.0/Azure.Mcp.Core.UnitTests /home/REDACTED/work/mcp/mcp/core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/bin/Debug/net9.0/Azure.Mcp.Core.UnitTests @@ /tmp/tmpjMLawZ.tmp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Merge azureterraformbestpractices command into get_azure_bestpractices</issue_title>
<issue_description>When virtual tool mode is enabled in VSCode (more than 128 tools are selected), copilot would group tools under one mcp server into 3-4 groups and then attach back tools based on embedding matching. When agent tried to get azure best practices, we've seen that it chose azureterraformbestpractices over get_azure_bestpractices. To eliminate the competition among our own tools, it is better to merge azureterraformbestpractices command into get_azure_bestpractices.
</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Merge azureterraformbestpractices into get_azure_bestpractices Merge azureterraformbestpractices into get_azure_bestpractices Jan 13, 2026
Copilot AI requested a review from fanyang-mono January 13, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

Merge azureterraformbestpractices command into get_azure_bestpractices

2 participants