-
Notifications
You must be signed in to change notification settings - Fork 356
Update Azure FileShares e2e test prompts #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revised Azure FileShares test prompts to use resource group and location parameters instead of storage account, and updated prompt wording for consistency and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Azure FileShares e2e test prompts to align with the actual API parameters used by the FileShares tools. The changes replace references to storage accounts with resource groups and locations, which accurately reflects how the FileShares API operates.
Changes:
- Updated all FileShares test prompts to use resource group and location parameters instead of storage account references
- Revised prompt wording for consistency (e.g., "provisioned storage" instead of "quota", "media tier" instead of "access tier")
- Fixed section heading from "Azure File Shares" to "Azure FileShares" for consistency
| | fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for file share <file_share_name> in resource group <resource_group_name> | | ||
| | fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations for file share <file_share_name> | | ||
| | fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings for file share <file_share_name>? | |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fileshares_fileshare_provisioningrecommendation_get command requires a location parameter, not a resource group. According to the command implementation (FileShareGetProvisioningRecommendationCommand), this command takes subscription and location as required parameters and provides recommendations based on storage size, not for a specific existing file share. The test prompt should be: 'Get provisioning recommendations for location with GB storage' or similar.
| | fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for file share <file_share_name> in resource group <resource_group_name> | | |
| | fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations for file share <file_share_name> | | |
| | fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings for file share <file_share_name>? | | |
| | fileshares_fileshare_provisioningrecommendation_get | Get provisioning recommendations for location <location> with <size> GB storage in subscription <subscription> | | |
| | fileshares_fileshare_provisioningrecommendation_get | Show me provisioning recommendations in location <location> for <size> GB of file share storage | | |
| | fileshares_fileshare_provisioningrecommendation_get | What are the recommended provisioning settings in location <location> for <size> GB of file share capacity? | |
| | fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in resource group <resource_group_name> | | ||
| | fileshares_fileshare_usage_get | Show me the usage statistics for file share <file_share_name> | | ||
| | fileshares_fileshare_usage_get | What is the current usage of file share <file_share_name>? | |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fileshares_fileshare_usage_get command requires a location parameter at the subscription level, not a specific file share or resource group. According to FileShareGetUsageDataCommand, it takes only subscription and location parameters to get usage data for a region. The test prompt should reference location instead: 'Get usage data for file shares in location ' or similar.
| | fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in resource group <resource_group_name> | | |
| | fileshares_fileshare_usage_get | Show me the usage statistics for file share <file_share_name> | | |
| | fileshares_fileshare_usage_get | What is the current usage of file share <file_share_name>? | | |
| | fileshares_fileshare_usage_get | Get usage data for file shares in location <location> | | |
| | fileshares_fileshare_usage_get | Show me the usage statistics for file shares in location <location> | | |
| | fileshares_fileshare_usage_get | What is the current file share usage in location <location>? | |
| | fileshares_fileshare_usage_get | Get usage data for file share <file_share_name> in storage account <account_name> | | ||
| | fileshares_fileshare_update | Update file share <file_share_name> in resource group <resource_group_name> | | ||
| | fileshares_fileshare_update | Update the provisioned storage for file share <file_share_name> to 200 GB | | ||
| | fileshares_fileshare_update | Change the media tier of file share <file_share_name> to Standard | |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The media tier values for FileShares are 'SSD' or 'HDD' according to the FileShareCreateCommand implementation, not 'Standard'. The test prompt should use a valid media tier value like 'SSD' or 'HDD'.
| | fileshares_fileshare_update | Change the media tier of file share <file_share_name> to Standard | | |
| | fileshares_fileshare_update | Change the media tier of file share <file_share_name> to SSD | |
Revised Azure FileShares test prompts to use resource group and location parameters instead of storage account, and updated prompt wording for consistency and clarity.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline