-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-nodes example & update doc #455
Merged
Merged
+91
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- python/test/configs/mscclpp_lang_test_config.json: Language not supported
- src/executor/executor.cc: Language not supported
- src/include/debug.h: Language not supported
Comments suppressed due to low confidence (1)
python/examples/allgather_allpairs_multinodes_packets.py:11
- The docstring should clearly explain the purpose of the gpus_per_node argument and ensure that the steps listed are complete or rephrase to avoid implying there are more steps.
def allgather_multinodes_allpair(gpus, gpus_per_node, instances):
chhwang
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation update:
docs/design/mscclpp-dsl.md
: Updated the link to the examples folder to reflect the correct path.New example script:
python/examples/allgather_allpairs_multinodes_packets.py
: Added a new example script demonstrating the allgather all-pairs algorithm across multiple nodes using packet communication.IR module improvements:
python/mscclpp/language/ir.py
: Refined the sorting criteria for GPU instance channels and thread block channels to include the channel type, ensuring a more accurate order.Debugging enhancements:
src/executor/executor.cc
: Added a debug log to indicate the start of communication collective execution with details about the execution plan and collective.src/include/debug.h
: Introduced a new debug log subsystem identifierMSCCLPP_EXECUTOR
for logging executor-related information.