Skip to content

Migrate ir_builder to use onnx_ir #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Migrate ir_builder to use onnx_ir #2457

wants to merge 31 commits into from

Conversation

justinchuby
Copy link
Collaborator

Signed-off-by: Justin Chu [email protected]

@justinchuby
Rename converter
69b08fb 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update fields
7e0a767 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
8c7abc6 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
make locals a stack
370a9f5 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
10473a9 
Signed-off-by: Justin Chu <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

❌ 176 Tests Failed:

Tests completed Failed Passed Skipped
176 176 0 0
View the top 3 failed test(s) by shortest run time 
::onnxscript.main
Stack Traces | 0s run time 
onnxscript\main.py:14: in <module>
    from onnxscript import _converter, ir, irbuilder, values
onnxscript\_converter.py:92: in <module>
    class DynamicKind(IntFlag):
                      ^^^^^^^
E   NameError: name 'IntFlag' is not defined
::onnxscript.rewriter.models._smollm_2
Stack Traces | 0s run time 
onnxscript\rewriter\models\_smollm_2.py:12: in <module>
    from onnxscript import script
onnxscript\__init__.py:69: in <module>
    from .main import export_onnx_lib, graph, script
onnxscript\main.py:14: in <module>
    from onnxscript import _converter, ir, irbuilder, values
onnxscript\_converter.py:92: in <module>
    class DynamicKind(IntFlag):
                      ^^^^^^^
E   NameError: name 'IntFlag' is not defined
::onnxscript.rewriter.onnx_fusions._rms_normalization
Stack Traces | 0s run time 
C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1126: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1126: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1126: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:940: in exec_module
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
onnxscript\__init__.py:69: in <module>
    from .main import export_onnx_lib, graph, script
onnxscript\main.py:14: in <module>
    from onnxscript import _converter, ir, irbuilder, values
onnxscript\_converter.py:92: in <module>
    class DynamicKind(IntFlag):
                      ^^^^^^^
E   NameError: name 'IntFlag' is not defined

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@justinchuby
wip
3889e70 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 16, 2025
View reviewed changes
@justinchuby
update
e09fdcc 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
fa60de6 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 16, 2025
View reviewed changes
onnxscript/_converter.py
op_signature, args, kwargs
)
args = [self._translate_opt_expr(x) for x in args]
onnx_inputs = [self._translate_opt_expr(x) for x in inputs]

Check warning

Code scanning / lintrunner

PYLINT/W0612 Warning

Unused variable 'onnx_inputs' (unused-variable)
See unused-variable. To disable, use # pylint: disable=unused-variable
onnxscript/_converter.py
op_signature, args, kwargs
)
args = [self._translate_opt_expr(x) for x in args]
onnx_inputs = [self._translate_opt_expr(x) for x in inputs]

Check warning

Code scanning / lintrunner

RUFF/F841 Warning

Local variable onnx\_inputs is assigned to but never used.
See https://docs.astral.sh/ruff/rules/unused-variable
onnxscript/_converter.py
elif kwargs.get(param.name) is not None:
attribute = kwargs[param.name] # type: ignore[assignment]
else:
if param.required:

Check notice

Code scanning / lintrunner

PYLINT/R1720 Note

Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise)
See no-else-raise. To disable, use # pylint: disable=no-else-raise
onnxscript/ir/_schemas.py
from __future__ import annotations

import collections.abc
import copy

Check warning

Code scanning / lintrunner

PYLINT/W0611 Warning

Unused import copy (unused-import)
See unused-import. To disable, use # pylint: disable=unused-import
onnxscript/ir/_schemas.py
from __future__ import annotations

import collections.abc
import copy

Check warning

Code scanning / lintrunner

RUFF/F401 Warning

copy imported but unused.
See https://docs.astral.sh/ruff/rules/unused-import
@justinchuby
wip
3aff171 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
761451a 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
882af66 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2025
View reviewed changes
onnxscript/_converter_test.py
top_level_ast = ast.parse(source)
f_ast = top_level_ast.body[0]
cvt = converter.Converter(
cvt = _converter.Converter(

Check failure

Code scanning / lintrunner

PYLINT/E1120 Error

No value for argument 'root' in constructor call (no-value-for-parameter)
See no-value-for-parameter. To disable, use # pylint: disable=no-value-for-parameter
onnxscript/main.py
# TODO: cleanup Converter interface/API, separating checker from
# converter
convert = converter.Converter(
convert = _converter.Converter(

Check failure

Code scanning / lintrunner

PYLINT/E1120 Error

No value for argument 'root' in constructor call (no-value-for-parameter)
See no-value-for-parameter. To disable, use # pylint: disable=no-value-for-parameter
onnxscript/values.py
global_names = module.__dict__.copy()
global_names.update(closure.nonlocals)
converter = converter_module.Converter(
converter = _converter.Converter(

Check failure

Code scanning / lintrunner

PYLINT/E1120 Error

No value for argument 'root' in constructor call (no-value-for-parameter)
See no-value-for-parameter. To disable, use # pylint: disable=no-value-for-parameter
@justinchuby
update
852cc42 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
continue
be610e9 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update analysis pass
98754ab 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
live_out
22eeddc 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 19, 2025
View reviewed changes
onnxscript/_internal/_analysis_test.py
def analyze(self, fun):
source, parse_tree = ast_utils.get_src_and_ast(fun)
analysis.do_liveness_analysis(parse_tree, formatter(source))
_analysis.do_liveness_analysis(parse_tree, formatter(source))

Check failure

Code scanning / lintrunner

PYLINT/E1120 Error

No value for argument 'meta' in function call (no-value-for-parameter)
See no-value-for-parameter. To disable, use # pylint: disable=no-value-for-parameter
@justinchuby
Update if
c74b854 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
fmt
2c43e9a 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update emit ordering
c53b8f3 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
update emit call
c84ad91 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
attrs
0af0707 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2025
View reviewed changes
@justinchuby
return values
2196f99 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2025
View reviewed changes
onnxscript/_internal/autocast.py
converter_: _converter.Converter,
op_schema: Optional[OpSchema],
args: Sequence[Optional[converter.Variable]],
args: Sequence[Optional[_converter.Variable]],

Check failure

Code scanning / lintrunner

MYPY/name-defined Error

Name "_converter.Variable" is not defined To disable, use # type: ignore[name-defined]
onnxscript/_internal/autocast.py
"""

def get_type_info(x: Optional[converter.Variable]) -> Optional[converter.Variable]:
def get_type_info(x: Optional[_converter.Variable]) -> Optional[_converter.Variable]:

Check failure

Code scanning / lintrunner

MYPY/name-defined Error

Name "_converter.Variable" is not defined To disable, use # type: ignore[name-defined]
onnxscript/_internal/autocast.py

def cast_like(
x: Optional[converter.Variable], y: Optional[converter.Variable]
x: Optional[_converter.Variable], y: Optional[_converter.Variable]

Check failure

Code scanning / lintrunner

MYPY/name-defined Error

Name "_converter.Variable" is not defined To disable, use # type: ignore[name-defined]
@justinchuby
wip
b56a161 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Merge branch 'main' into justinchu/migrate-irbuilder
359eb0b
@justinchuby
wip
b04a455 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
wip
e4c9576 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2025
View reviewed changes
onnxscript/_converter.py
tensor = autocast.pyvalue_to_onnx_tensor(ovar, pyvalue)
except ValueError as e:
tensor = ir.tensor(pyvalue, name=var_name)
except Exception as e:

Check warning

Code scanning / lintrunner

PYLINT/W0718 Warning

Catching too general exception Exception (broad-exception-caught)
See broad-exception-caught. To disable, use # pylint: disable=broad-exception-caught
onnxscript/_converter.py
preferred_name = f"return_val{suffix}"
return_var = self._translate_expr(exp, preferred_name).name
val = self._lookup(return_var, self._source_of(exp), False)
assert type(val) is values.Dynamic

Check notice

Code scanning / lintrunner

PYLINT/C0123 Note

Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
See unidiomatic-typecheck. To disable, use # pylint: disable=unidiomatic-typecheck
@justinchuby
refactor
11a735e 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 29, 2025
View reviewed changes
onnxscript/_converter.py
return tuple(reversed(inputs_reversed)), named_attrs


def _to_onnx_ref_attr(val: values.AttrRef, info: sourceinfo.SourceInfo | None) -> ir.Attr:

Check failure

Code scanning / lintrunner

MYPY/name-defined Error

Name "values.AttrRef" is not defined To disable, use # type: ignore[name-defined]
onnxscript/values.py

from onnxscript import converter as converter_module
from onnxscript import irbuilder, sourceinfo, type_annotation
from onnxscript import _converter, irbuilder, sourceinfo, type_annotation

Check warning

Code scanning / lintrunner

PYLINT/W0611 Warning

Unused sourceinfo imported from onnxscript (unused-import)
See unused-import. To disable, use # pylint: disable=unused-import
onnxscript/values.py

from onnxscript import converter as converter_module
from onnxscript import irbuilder, sourceinfo, type_annotation
from onnxscript import _converter, irbuilder, sourceinfo, type_annotation

Check warning

Code scanning / lintrunner

RUFF/F401 Warning

onnxscript.sourceinfo imported but unused.
See https://docs.astral.sh/ruff/rules/unused-import
@justinchuby
_ValueEnvironment
0cd1f20 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
emit_const
d98e8b5 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 30, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2025
View reviewed changes
onnxscript/_converter.py
Sequence,
Tuple,
Union,
_GenericAlias

Check warning

Code scanning / lintrunner

RUFF/F401 Warning

typing.\_GenericAlias imported but unused.
See https://docs.astral.sh/ruff/rules/unused-import
onnxscript/_converter.py
"""
self.name = name
self.is_castable = castable
class DynamicKind(IntFlag):

Check failure

Code scanning / lintrunner

PYLINT/E0602 Error

Undefined variable 'IntFlag' (undefined-variable)
See undefined-variable. To disable, use # pylint: disable=undefined-variable
onnxscript/_converter.py
"""
self.name = name
self.is_castable = castable
class DynamicKind(IntFlag):

Check failure

Code scanning / lintrunner

RUFF/F821 Error

Undefined name IntFlag.
See https://docs.astral.sh/ruff/rules/undefined-name
onnxscript/_converter.py
"""
self.name = name
self.is_castable = castable
class DynamicKind(IntFlag):

Check failure

Code scanning / lintrunner

MYPY/name-defined Error

Name "IntFlag" is not defined To disable, use # type: ignore[name-defined]
onnxscript/_converter.py
self._converter = converter

def get_or_create_value(
self, var: str, info: sourceinfo.SourceInfo

Check warning

Code scanning / lintrunner

PYLINT/W0613 Warning

Unused argument 'info' (unused-argument)
See unused-argument. To disable, use # pylint: disable=unused-argument
@justinchuby
fixme
ce2428f 
Signed-off-by: Justin Chu <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2025
View reviewed changes
onnxscript/_converter.py
def is_base_type_bool(attr: ir.Attr) -> bool:
"""Check if the attribute is a boolean type."""
# FIXME: Add meta to attributes
attr.meta[_SOURCEINFO_FIELD]

Check warning

Code scanning / lintrunner

PYLINT/W0104 Warning

Statement seems to have no effect (pointless-statement)
See pointless-statement. To disable, use # pylint: disable=pointless-statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

ONNX Script Review Board
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justinchuby