-
Notifications
You must be signed in to change notification settings - Fork 86
Support torch_export_patches #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
==========================================
- Coverage 70.09% 60.34% -9.76%
==========================================
Files 214 224 +10
Lines 25791 27321 +1530
Branches 2581 2963 +382
==========================================
- Hits 18078 16486 -1592
- Misses 6818 10008 +3190
+ Partials 895 827 -68 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ONNX = "onnx==1.18" | ||
ONNX_RUNTIME = "onnxruntime==1.22.1" | ||
PYTORCH = "torch==2.8.0" | ||
TORCHVISON = "torchvision==0.23" | ||
TRANSFORMERS = "transformers==4.55.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep this the lowest versions supported; or create different pipelines that run on different versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that this is not at the top level because this is not the main responsibility of onnxscript
What is the plan for phasing the patches out, assuming they are temporary? |
No description provided.