Skip to content

Conversation

titaiwangms
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 7.51634% with 1415 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.34%. Comparing base (3af04e9) to head (78f7702).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/torch_export_patches/_verbose.py 0.00% 362 Missing ⚠️
...script/torch_export_patches/_patch_transformers.py 22.22% 331 Missing and 5 partials ⚠️
onnxscript/torch_export_patches/_core.py 4.21% 182 Missing ⚠️
onnxscript/torch_export_patches/_cache_creator.py 0.00% 152 Missing ⚠️
...ipt/torch_export_patches/_treenode_transformers.py 0.00% 104 Missing ⚠️
...xscript/torch_export_patches/_treenode_registry.py 3.00% 97 Missing ⚠️
onnxscript/torch_export_patches/_type_utils.py 0.00% 89 Missing ⚠️
onnxscript/torch_export_patches/_patch_torch.py 5.95% 79 Missing ⚠️
...script/torch_export_patches/_treenode_diffusers.py 0.00% 14 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3af04e9) and HEAD (78f7702). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3af04e9) HEAD (78f7702)
21 19
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   70.09%   60.34%   -9.76%     
==========================================
  Files         214      224      +10     
  Lines       25791    27321    +1530     
  Branches     2581     2963     +382     
==========================================
- Hits        18078    16486    -1592     
- Misses       6818    10008    +3190     
+ Partials      895      827      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Comment on lines +32 to +36
ONNX = "onnx==1.18"
ONNX_RUNTIME = "onnxruntime==1.22.1"
PYTORCH = "torch==2.8.0"
TORCHVISON = "torchvision==0.23"
TRANSFORMERS = "transformers==4.55.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep this the lowest versions supported; or create different pipelines that run on different versions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that this is not at the top level because this is not the main responsibility of onnxscript

@justinchuby
Copy link
Collaborator

What is the plan for phasing the patches out, assuming they are temporary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants