-
Notifications
You must be signed in to change notification settings - Fork 86
Add a verbose mode to torch api for external data save #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Justin Chu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds an optional verbose flag to save_model_with_external_data to display progress via tqdm when available.
- Extends function signature with verbose parameter (default False).
- Implements conditional tqdm progress bar callback.
- Introduces dynamic import/tqdm detection logic.
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2643 +/- ##
==========================================
+ Coverage 70.32% 70.43% +0.10%
==========================================
Files 222 224 +2
Lines 26438 26585 +147
Branches 2632 2639 +7
==========================================
+ Hits 18593 18724 +131
- Misses 6926 6940 +14
- Partials 919 921 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Chu <[email protected]>
Show progress bar with tqdm when verbose is True.