Revert exception handling changes#45
Merged
swesonga merged 4 commits intoms-patches/win-aarch64-fixesfrom Jan 6, 2026
Merged
Conversation
macarte
approved these changes
Jan 6, 2026
Contributor
macarte
left a comment
macarte
left a comment
There was a problem hiding this comment.
LGTM (I compared these commits with the original commits)
swesonga
merged commit 990640d
into
ms-patches/win-aarch64-fixes
123 of 127 checks passed
Luigi96
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Revert "Do not report errors unless FAILED returns true for the exception code (#16)" This reverts commit 5fa147b. * Revert "Perform error reporting for uncaught native exceptions (#11)" This reverts commit 07c3446. * Revert "Fix bug causing missing core dumps on Windows AArch64" This reverts commit 3ef2c63. * Revert "Windows AArch64 safefetch implementation should not use structured exception handling" This reverts commit 62651d6.
Luigi96
pushed a commit
that referenced
this pull request
Feb 14, 2026
* Revert "Do not report errors unless FAILED returns true for the exception code (#16)" This reverts commit 5fa147b. * Revert "Perform error reporting for uncaught native exceptions (#11)" This reverts commit 07c3446. * Revert "Fix bug causing missing core dumps on Windows AArch64" This reverts commit 3ef2c63. * Revert "Windows AArch64 safefetch implementation should not use structured exception handling" This reverts commit 62651d6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests end with core dumps caused by EXCEPTION_GUARD_PAGE after these changes.