Repo: Update to Rust 1.87 #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
changed the title
|
Eek that binary size jump |
smalis-msft
changed the title
|
I bisected the binary size change to rust-lang/rust#137500, which may get clawed back somewhat by llvm/llvm-project#134093 and rust-lang/rust#124533. I think we just have to take this. |
jstarks
approved these changes
May 21, 2025
|
Could also possibly be fixed by llvm/llvm-project#134908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up the last few lints needed to be clean on 1.87 that weren't backwards-compatible with 1.86. Mostly this is adding expects for clippy::large_enum_variant, which is now able to process more types. I stared at all the cases for a few minutes, and I don't think they're in places that are impactful enough to be worth changing.