vmm_tests: Use 1.7 release version for servicing tests #2460
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the VMM servicing tests to use the newly released 1.7 (2511) version instead of the previous 1.6 (2505) release. The changes rename artifact references from RELEASE_25_05_* to LATEST_RELEASE_* and update the underlying version from Release2505 to Release2511 throughout the codebase.
Key Changes
- Renamed artifact constants from
RELEASE_25_05_*pattern toLATEST_RELEASE_*pattern to represent the new latest release (2511 instead of 2505) - Updated version enum to include
Release2511alongside existing versions - Updated file path generation to use "release-2511" prefixes for binary names
- Configured branch name as "release/1.7.2511" for downloading artifacts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs | Updated test artifact imports and test configurations to use LATEST_RELEASE_* artifacts pointing to 2511 release |
| vmm_tests/petri_artifacts_vmm_test/src/lib.rs | Renamed artifact constants from RELEASE_25_05_* to LATEST_RELEASE_* and updated their trait implementations |
| vmm_tests/petri_artifact_resolver_openvmm_known_paths/src/lib.rs | Updated artifact resolution logic to map LATEST_RELEASE_* artifacts to Release2511 version and updated file paths to use "release-2511" prefix |
| flowey/flowey_lib_hvlite/src/download_release_igvm_files_from_gh.rs | Added Release2511 enum variant with branch name "release/1.7.2511" and updated ALL array and Display implementation |
Co-authored-by: Copilot <[email protected]>
mattkur
added
the
release-ci-required
mattkur
left a comment
mattkur
left a comment
There was a problem hiding this comment.
Overall this looks reasonable, and thank you for doing this. A few things:
- Please stage any fixups to the closed source repos, if required.
- Note to self for me: upgrade/downgrade tests should now use nvme keepalive
- CI failed; we can check again after seeing green tests.
- I kicked off release CI "just in case"
…nvmm into 1.7-servicing-tests
|
We should also update the internal guide's 'new release branch' list to mention this. That one's more complete |
| description. This signals to the reviewer that extra care is needed during | ||
| the review process. | ||
|
|
||
| #### Updating Servicing Tests |
There was a problem hiding this comment.
This should get moved to the internal guide, where we have a complete list of 'things to do when forking a new release branch'
There was a problem hiding this comment.
Probably moved, just to make sure all the info stays in the same place
3 participants
Since we have recently forked and created a 1.7 release branch, we should start using the 1.7 release in our servicing upgrade/downgrade tests.
Open questions: