flowey: remove echo for bootstrap flowey #2474
Merged
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justus-camp-microsoft
approved these changes
Nov 21, 2025
Contributor
justus-camp-microsoft
left a comment
justus-camp-microsoft
left a comment
There was a problem hiding this comment.
I don't find those log messages useful either. If anything, it just muddies up the log for something the vast majority of people don't care about.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a non-functional bootstrap echo step from the ADO YAML pipeline resolver that was causing failures on Windows CI images without bash.exe in the PATH. The echo step provided no value and was an unnecessary dependency on bash for the bootstrapping process.
Key changes:
- Removed the
echo "injected!"bash step from the flowey bootstrap process in ADO pipelines
Member
Author
Agreed. |
benhillis
changed the title
chris-oo
approved these changes
Nov 21, 2025
benhillis
added
backport_1.7.2511
backported_1.7.2511
Member
Author
|
Backported in #2490. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This echo isn't adding anything valuable and is actually causing some issues with our internal ADO pipelines. For some additional context we have some Windows CI images that do not have the
bash.exein the path, which makes this task fail. I'm working on getting those images fixed, but in the meantime, this will allow the bootstrapping to succeed on these images.