Skip to content

chore: move junit tests into junit package #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/src/test/java/com/microsoft/playwright/Server.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private Auth(String user, String password) {
}
}

static Server createHttp(int port) throws IOException {
public static Server createHttp(int port) throws IOException {
return new Server(port, false);
}

Expand Down Expand Up @@ -81,7 +81,7 @@ private Server(int port, boolean https) throws IOException {
server.start();
}

void stop() {
public void stop() {
server.stop(0);
}

Expand Down
4 changes: 2 additions & 2 deletions playwright/src/test/java/com/microsoft/playwright/Utils.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

class Utils {
public class Utils {
private static final AtomicInteger nextUnusedPort = new AtomicInteger(9000);

private static boolean available(int port) {
Expand All @@ -47,7 +47,7 @@ private static boolean available(int port) {
}
}

static int nextFreePort() {
public static int nextFreePort() {
for (int i = 0; i < 100; i++) {
int port = nextUnusedPort.getAndIncrement();
if (available(port)) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.extension.ExtendWith;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.Server;
import org.junit.jupiter.api.extension.AfterAllCallback;
import org.junit.jupiter.api.extension.BeforeAllCallback;
import org.junit.jupiter.api.extension.ExtensionContext;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.junit.Options;
import com.microsoft.playwright.junit.OptionsFactory;
import com.microsoft.playwright.junit.UsePlaywright;
import com.microsoft.playwright.Browser;
import com.microsoft.playwright.Page;
import com.microsoft.playwright.Server;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledIf;

import static com.microsoft.playwright.ServerLifecycle.serverMap;
import static com.microsoft.playwright.junit.ServerLifecycle.serverMap;
import static org.junit.jupiter.api.Assertions.*;

@FixtureTest
@UsePlaywright(TestPlaywrightCustomFixturesChannel.CustomOptions.class)
@UsePlaywright(TestFixtureChannelOption.CustomOptions.class)
@EnabledIf("isChannelSpecified")
public class TestPlaywrightCustomFixturesChannel {
public class TestFixtureChannelOption {

public static class CustomOptions implements OptionsFactory {
@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.junit.Options;
import com.microsoft.playwright.junit.OptionsFactory;
import com.microsoft.playwright.junit.UsePlaywright;
import com.microsoft.playwright.*;
import org.junit.jupiter.api.Test;

import java.util.regex.Pattern;

import static com.microsoft.playwright.ServerLifecycle.serverMap;
import static com.microsoft.playwright.junit.ServerLifecycle.serverMap;
import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

@FixtureTest
@UsePlaywright(TestPlaywrightCustomOptionFixtures.CustomOptions.class)
public class TestPlaywrightCustomOptionFixtures {
@UsePlaywright(TestFixtureContextOptions.CustomOptions.class)
public class TestFixtureContextOptions {

public static class CustomOptions implements OptionsFactory {
@Override
public Options getOptions() {
return new Options().setApiRequestOptions(new APIRequest.NewContextOptions().setBaseURL(serverMap.get(TestPlaywrightCustomOptionFixtures.class).EMPTY_PAGE)).setContextOption(new Browser.NewContextOptions().setBaseURL(serverMap.get(TestPlaywrightCustomOptionFixtures.class).EMPTY_PAGE));
return new Options()
.setApiRequestOptions(new APIRequest.NewContextOptions()
.setBaseURL(serverMap.get(TestFixtureContextOptions.class).EMPTY_PAGE))
.setContextOption(new Browser.NewContextOptions()
.setBaseURL(serverMap.get(TestFixtureContextOptions.class).EMPTY_PAGE));
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.junit.Options;
import com.microsoft.playwright.junit.OptionsFactory;
import com.microsoft.playwright.junit.UsePlaywright;
import com.microsoft.playwright.Page;
import com.microsoft.playwright.Server;
import org.junit.jupiter.api.Test;

import static com.microsoft.playwright.ServerLifecycle.serverMap;
import static com.microsoft.playwright.junit.ServerLifecycle.serverMap;
import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;

@FixtureTest
@UsePlaywright(TestPlaywrightDeviceOption.CustomOptions.class)
public class TestPlaywrightDeviceOption {
@UsePlaywright(TestFixtureDeviceOption.CustomOptions.class)
public class TestFixtureDeviceOption {

public static class CustomOptions implements OptionsFactory {
@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -1,30 +1,31 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.junit.Options;
import com.microsoft.playwright.junit.OptionsFactory;
import com.microsoft.playwright.junit.UsePlaywright;
import com.microsoft.playwright.Browser;
import com.microsoft.playwright.Page;
import org.junit.jupiter.api.Test;

import java.util.regex.Pattern;

import static com.microsoft.playwright.ServerLifecycle.serverMap;
import static com.microsoft.playwright.junit.ServerLifecycle.serverMap;
import static com.microsoft.playwright.assertions.PlaywrightAssertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;

@FixtureTest
@UsePlaywright(TestPlaywrightCustomFixtures.CustomOptions.class)
public class TestPlaywrightCustomFixtures {
@UsePlaywright(TestFixtureOptions.CustomOptions.class)
public class TestFixtureOptions {

public static class CustomOptions implements OptionsFactory {
@Override
public Options getOptions() {
return new Options().setBaseUrl(serverMap.get(TestPlaywrightCustomFixtures.class).EMPTY_PAGE).setBrowserName("firefox");
return new Options()
.setBaseUrl(serverMap.get(TestFixtureOptions.class).EMPTY_PAGE)
.setBrowserName("webkit");
}
}

@Test
public void testCustomBrowser(Browser browser) {
assertEquals(browser.browserType().name(), "firefox");
assertEquals(browser.browserType().name(), "webkit");
}

@Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package com.microsoft.playwright;
package com.microsoft.playwright.junit;

import com.microsoft.playwright.junit.UsePlaywright;
import com.microsoft.playwright.*;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

@UsePlaywright
public class TestPlaywrightFixtures {
public class TestFixtures {
private static Playwright playwrightFromBeforeAll;
private static Browser browserFromBeforeAll;
private BrowserContext browserContextFromBeforeEach;
Expand Down