-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix Windows browser process close test #34469
base: main
Are you sure you want to change the base?
chore: fix Windows browser process close test #34469
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any failures on Windows, is it something that you observed locally?
tests/library/signals.spec.ts
Outdated
@@ -26,7 +26,7 @@ test('should close the browser when the node process closes', async ({ startRemo | |||
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); | |||
try { | |||
if (isWindows) | |||
execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`, { stdio: 'ignore' }); | |||
execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this help?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests others"2 failed 21564 passed, 503 skipped Merge workflow run. |
Test results for "tests 1"6 failed 17 flaky37692 passed, 649 skipped Merge workflow run. |
Test results for "tests 2"3 fatal errors, not part of any test 140 flaky254253 passed, 9763 skipped Merge workflow run. |
No description provided.