test: isolate Electron userDataDir per-test #35235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 17, 2025
tests/electron/electron-app.js
Outdated
| const { app, protocol } = require('electron'); | ||
| const path = require('path'); | ||
|
|
||
| assert(process.argv.length > 0, 'No arguments provided. First argument needs to be a userDataDir.'); | ||
| app.setPath('appData', process.argv[2]); |
There was a problem hiding this comment.
Make sure we don't use it outside the tests that pass the dir.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"6 flaky38782 passed, 808 skipped Merge workflow run. |
Test results for "tests others"12 fatal errors, not part of any test 21739 passed, 512 skipped Merge workflow run. |
Test results for "tests 2"1 fatal errors, not part of any test 106 flaky236484 passed, 9285 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from here. Before this patch Electron has shared the cookies across different test-runs.