fix(headers): keep set-cookie expires intact on webkit #38312
Closed
+76
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
yury-s
reviewed
Nov 21, 2025
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Before jumping to the implementation, please clarify (in the linked issue) what user-facing problem you are trying to solve.
| */ | ||
|
|
||
| import { test, expect } from '@playwright/test'; | ||
| import { headersObjectToArray } from '../../../packages/playwright-core/src/utils/isomorphic/headers'; |
Member
There was a problem hiding this comment.
We normally don't test internals with unit tests and prefer end-to-end tests that call public APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix WebKit/macOS Set-Cookie splitting so Expires commas don’t swallow additional cookies.
Add regression unit test covering single Expires + multiple cookies.
Issue:
Fixes #38311
Testing:
npm run ctest -- tests/library/unit/headers.spec.ts
(Optional) Note: full npm run ctest hit two SOCKS/IPv6 proxy infra failures, unrelated to this change.