Fixed a bug that resulted in a false positive when a contravariant Ty…

…peVar was used in a return type in a non-method.
microsoft · Jan 14, 2024 · 7d38c9a · 7d38c9a
1 parent f35d4f3
commit 7d38c9a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -163,6 +163,7 @@ import {
     Type,
     TypeBase,
     TypeCategory,
+    TypeVarScopeType,
     TypeVarType,
     TypedDictEntry,
     UnknownType,
@@ -4736,7 +4737,11 @@ export class Checker extends ParseTreeWalker {
         let isContraTypeVar = false;
 
         doForEachSubtype(returnType, (subtype) => {
-            if (isTypeVar(subtype) && subtype.details.declaredVariance === Variance.Contravariant) {
+            if (
+                isTypeVar(subtype) &&
+                subtype.details.declaredVariance === Variance.Contravariant &&
+                subtype.scopeType === TypeVarScopeType.Class
+            ) {
                 isContraTypeVar = true;
             }
         });