fix: pre-commit config: bump pycln to working version after PyYAML v5.X dependencies stopped working #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendencies stopped working
TaoK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template's "devcontainer" wasn't working, with an obscure error about "AttributeError: cython_sources" during a pip install, in a "Called Process" - see #151.
After some investigation it turned out that this was happening during the devContainer's
onCreateCommand, which runspre-commit install-hooks.Searching for other projects with the same error showed that one typical solution is to upgrade to PyYAML 6.X, but as the version of PyYAML in this particular
pip installis actually driven by thefrom pycln==1.2.5constraint, that's what needs to be bumped for this template to start working again.Fixes #151.