Add aria-required and aria-multiselectable to accessibilityState on win32 #12046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Aug 18, 2023
packages/@office-iss/react-native-win32/src/Libraries/Components/Button.win32.js
Outdated
Show resolved
Hide resolved
Saadnajmi
reviewed
Aug 18, 2023
packages/@office-iss/react-native-win32/src/Libraries/Components/Button.win32.js
Outdated
Show resolved
Hide resolved
ksiler
changed the title
rurikoaraki
reviewed
Aug 23, 2023
packages/@office-iss/react-native-win32/src/Libraries/Components/Text/TextWin32.Props.ts
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Aug 23, 2023
rurikoaraki
approved these changes
Aug 23, 2023
ksiler
added a commit
to ksiler/react-native-windows
that referenced
this pull request
Aug 23, 2023
…in32 (microsoft#12046) * add missing a11yState props on win32 * Change files * fix missing a11yState props for other components * minor fix * add aria- equivalent props * edit change file comment * Add win32 comment tags * lint fix * fix lint errors * add aria- props to textprops * remove unneeded props
ksiler
added a commit
to ksiler/react-native-windows
that referenced
this pull request
Aug 23, 2023
…in32 (microsoft#12046) * add missing a11yState props on win32 * Change files * fix missing a11yState props for other components * minor fix * add aria- equivalent props * edit change file comment * Add win32 comment tags * lint fix * fix lint errors * add aria- props to textprops * remove unneeded props
ksiler
added a commit
that referenced
this pull request
Aug 23, 2023
…in32 (#12046) (#12062) * add missing a11yState props on win32 * Change files * fix missing a11yState props for other components * minor fix * add aria- equivalent props * edit change file comment * Add win32 comment tags * lint fix * fix lint errors * add aria- props to textprops * remove unneeded props
ksiler
added a commit
that referenced
this pull request
Aug 23, 2023
…in32 (#12046) (#12061) * add missing a11yState props on win32 * Change files * fix missing a11yState props for other components * minor fix * add aria- equivalent props * edit change file comment * Add win32 comment tags * lint fix * fix lint errors * add aria- props to textprops * remove unneeded props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds aria-required and aria-multiselectable as props on win32 and adds them to accessibilityState (along with missing
requiredandmultiselectablefileds)Type of Change
Why
aria- props exist for these props and
requiredandmultiselectablewere missing from accessibilityState on win32#12047
What
Adds
requiredandmultiselectableto accessibilityState on win32Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: indicate yes or no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow