Use Hermes version 0.0.0-2510.15001-6f45e5b5 #15255
Conversation
vnext/fmt/packages.lock.json
Outdated
There was a problem hiding this comment.
we need to remove this file .
| <ClCompile Include="$(MSBuildThisFileDirectory)..\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.cpp" /> | ||
| <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\network\NetworkReporter.cpp" /> | ||
| <ClCompile Include="$(MSBuildThisFileDirectory)..\Microsoft.ReactNative\Fabric\Composition\TextInput\WindowsTextInputState.cpp" /> | ||
| <ClCompile Include="$(ReactNativeDir)\ReactCommon\runtimeexecutor\platform\cxx\ReactCommon\RuntimeExecutorSyncUIThreadUtils.cpp" /> |
There was a problem hiding this comment.
Just a question: why we need to add this file ?
There was a problem hiding this comment.
This change is in a .filter file. It is used by Visual Studio to show files in the solution explorer. The entries in this file may be added or removed automatically when the main project file has it, but the author forgot to commit the corresponding changes to the .filter file. This file does not affect the compilation, but since the original author did not commit it at the right time, now everyone who opens the solution file will see this change happening. It is better to commit it at last to free other people seeing this change again and again.
I cannot immediately answer why this entry is needed in the Shared.vcxitems project. I guess, it can be found from history of that project. Hopefully the PR author left a good comment there.
2 participants
Description
Type of Change
Why
We should switch to new version of
hermes-windowsandnode-api-jsito unblock our progress with adoption of new Hermes debugger. This version of Hermes contains all latest changes to Node-API code that we did to prepare PR to upstream the Node-API implementation tofacebook/hermesrepo (facebook/hermes#1377).What
vnext/PropertySheets/JSEngine.propsfile to0.0.0-2510.15001-6f45e5b5.vnext\Scripts\NuGetRestoreForceEvaluateAllSolutions.ps1script to update allpackages.lock.jsonfiles.hermes-windowsuses two new Node-API filesnode_api.handnode_api_types.hwe have to intgrate thenode-api-jsiPR that updates Node-API files: Update Node-API files node-api-jsi#15.node-api-jsicommit hash is updated to78317af4798297dad5a17b2a07f5dfc712040b7ainvnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitemsandvnext/Directory.Build.propsfiles.node_api.handnode_api_types.hare added tovnext/Scripts/Tfs/Layout-MSRN-Headers.ps1andvnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitemsfiles.Testing
The playground-composition app seems to be running OK.
Changelog
Should this change be included in the release notes: yes
Use Hermes version 0.0.0-2510.15001-6f45e5b5
Microsoft Reviewers: Open in CodeFlow