Debugger outstanding issues #15392
Open
Debugger outstanding issues #15392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8b0b38.
This was referenced Nov 20, 2025
13 tasks
vmoroz
reviewed
Nov 24, 2025
| static void SetUIThreadDispatcher(IReactPropertyBag const &properties) noexcept; | ||
|
|
||
| static IReactPropertyName JSDispatcherProperty() noexcept; | ||
| static IReactDispatcher GetJSDispatcher(IReactPropertyBag const &properties) noexcept; |
Member
There was a problem hiding this comment.
Please keep the IReactDispatcher.h and IReactDispatcher.cpp files unchanged.
Let's keep the access to the JS dispatcher as we do it for the UI Dispatcher.
vmoroz
reviewed
Nov 24, 2025
| winrt::Windows::Foundation::IAsyncOperation<winrt::hstring> getApplicationDataPath(const wchar_t *childfolder); | ||
|
|
||
| // string formatting | ||
| std::string string_format(_Printf_format_string_ const char *format, ...); |
Member
There was a problem hiding this comment.
The string_format name does not play well with other naming conventions that we have. We mostly use the Pascal naming conventions. Also, the function should typically start with a verb. Could you please change it to FormatString?
vmoroz
reviewed
Nov 24, 2025
|
|
||
| TEST_METHOD(UtilsTest_StringFormat_Simple) | ||
| { | ||
| auto result = Microsoft::React::string_format("Hello, %s!", "World"); |
Member
There was a problem hiding this comment.
Please avoid using auto unless you absolutely must use it.
Having the std::string here in the new code is much more readable.
Contributor
There was a problem hiding this comment.
curious, why avoid auto? I've never actually known what is better style
vmoroz
reviewed
Nov 24, 2025
|
|
||
| TEST_METHOD(UtilsTest_StringFormat_EmptyString) | ||
| { | ||
| auto result = Microsoft::React::string_format(""); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1> Provides the real process ID to the RuntimeSamplingProfile constructor
2>Remove DevSupportManager::OpenDevTools not needed with modern inspector infra
3> move string_format to Microsoft::React namespace
4> Remove support for the old sampling profiler
Type of Change
Why
solves modern Inspector Outstanding Issues
Resolves [Add Relevant Issue Here]
#15349
What
1> Provides the real process ID to the RuntimeSamplingProfile constructor
2>Remove DevSupportManager::OpenDevTools not needed with modern inspector infra
3> move string_format to Microsoft::React namespace
Screenshots
Testing
tested locally on playground and added unittests for string_format changes.
Changelog
Should this change be included in the release notes: indicate no
Microsoft Reviewers: Open in CodeFlow