Skip to content

feat: existing resources support with azd up #46

Merged
Yamini-Microsoft merged 9 commits intodevfrom
psl-existing-resources-support
Feb 25, 2026
Merged

feat: existing resources support with azd up #46
Yamini-Microsoft merged 9 commits intodevfrom
psl-existing-resources-support

Conversation

@Yamini-Microsoft
Copy link
Collaborator

Purpose

  • This pull request introduces significant improvements to the deployment process by adding support for reusing existing Azure resources and simplifying the documentation for customizing deployments. The changes enhance flexibility for users who want to leverage existing Event Hub namespaces, Event Hubs, and Fabric Capacities, and provide clearer instructions for advanced configuration scenarios.

Deployment customization and resource reuse:

  • Added parameters in infra/main.bicep to allow the use of existing Event Hub Namespace, Event Hub, and Fabric Capacity, enabling deployments to reuse resources instead of always creating new ones.
  • Updated resource creation logic in infra/main.bicep to conditionally reference or create Event Hub Namespace and Event Hub based on provided parameters, and to conditionally create Fabric Capacity. [1] [2]
  • Modified outputs in infra/main.bicep to reflect whether existing resources were used and to provide additional deployment context, such as resource group location and usage flags.

Documentation improvements:

  • Refactored docs/DeploymentGuide.md to clarify advanced configuration, grouping environment variable settings by common scenarios (alert email, resource reuse), and providing detailed instructions for deploying with existing resources.
  • Added collapsible sections in docs/DeploymentGuide.md for permission checks, tool verification, and deployment options, making the guide more navigable and user-friendly. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated troubleshooting guidance in docs/DeploymentGuide.md to reference a dedicated troubleshooting document for common deployment issues.

Other improvements:

  • Revised post-deployment instructions to direct users to a summary of deployed resources rather than a list of features, streamlining next steps.
  • Added parameter and variable section headers in infra/main.bicep for better readability and maintainability. [1] [2]

These changes together make deployments more flexible, documentation clearer, and troubleshooting easier for users.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Yamini-Microsoft and others added 4 commits February 11, 2026 23:31
- Add parameters for existing Event Hub Namespace, Event Hub, and Fabric Capacity
- Support three scenarios: create all new, use existing namespace with new Event Hub, use all existing
- Update outputs to handle both new and existing resource scenarios
- Update DeploymentGuide.md with usage examples and configuration reference
- Require Event Hub resources to be in the same resource group as deployment
- Make deployment guide more readable with collapsible sections
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces support for reusing existing Azure resources (Event Hub Namespace, Event Hub, and Fabric Capacity) during deployment, enabling cost optimization and flexibility for users who want to leverage pre-existing infrastructure. The PR also refactors the deployment documentation to provide clearer, more organized guidance with collapsible sections and specific instructions for using existing resources.

Changes:

  • Added Bicep parameters and conditional logic to support existing Event Hub Namespace, Event Hub, and Fabric Capacity resources
  • Updated Python deployment script to resolve Event Hub resource group correctly when reusing existing resources
  • Reorganized deployment documentation with collapsible sections and comprehensive instructions for resource reuse scenarios

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
infra/main.bicep Added parameters for existing resources, implemented conditional resource creation logic, and updated outputs to reflect resource usage
infra/main.parameters.json Added parameter mappings for existing resource names from environment variables
infra/scripts/fabric/deploy_fabric_rti.py Added Event Hub resource group resolution logic and reformatted docstring for better readability
docs/DeploymentGuide.md Restructured documentation with collapsible sections, added detailed instructions for using existing resources, and clarified deployment requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Update Bicep parameter description and code comments
- Add note in deployment guide that Event Hub name requires namespace
- Prevent misconfiguration where only Event Hub name is set
- Grant Data Sender role when using existing Event Hub namespace
- Add BCP318 suppression for Event Hub module outputs (consistent with Fabric)
- Document automatic role assignment in deployment guide
- Correct Configuration Settings anchor from 'advanced-configuration' to 'optional'
- Ensures table of contents links navigate correctly to Step 3 heading
@Yamini-Microsoft Yamini-Microsoft changed the base branch from main to dev February 16, 2026 11:57
@Yamini-Microsoft Yamini-Microsoft merged commit dfe0b07 into dev Feb 25, 2026
4 checks passed
@Yamini-Microsoft Yamini-Microsoft deleted the psl-existing-resources-support branch February 25, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants