Skip to content

Commit

Permalink
fix(buildx): docker fail on pull rate limit, --driver-opt (#995)
Browse files Browse the repository at this point in the history
# Description

docker rate limiting is now impacting buildkit usage. Explicitly pass
mcr image

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
  • Loading branch information
SRodi authored Nov 12, 2024
1 parent 8c3965d commit 6c6c5a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ buildx:
echo "Buildx instance retina already exists."; \
else \
echo "Creating buildx instance retina..."; \
docker buildx create --name retina --use --platform $$(echo "$(PLATFORMS)" | tr ' ' ','); \
docker buildx create --name retina --use --driver-opt image=mcr.microsoft.com/oss/v2/moby/buildkit:v0.16.0-2 --platform $$(echo "$(PLATFORMS)" | tr ' ' ','); \
docker buildx use retina; \
echo "Buildx instance retina created."; \
fi;
Expand Down

0 comments on commit 6c6c5a7

Please sign in to comment.