[heft-lint-plugin] fix: eslint doesn't cache output correctly #5107
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aramis Sennyey <[email protected]>
aramissennyeydd
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
Signed-off-by: Aramis Sennyey <[email protected]>
Signed-off-by: Aramis Sennyey <[email protected]>
iclanton
reviewed
Feb 20, 2025
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/heft-lint-plugin", | ||
| "comment": "Fix the cache only populating for incremental Typescript builds.", |
There was a problem hiding this comment.
Suggested change
| "comment": "Fix the cache only populating for incremental Typescript builds.", | |
| "comment": "Fix an issue where the cache is only populated for incremental TypeScript builds.", |
| @@ -138,8 +138,15 @@ export abstract class LinterBase<TLintResult> { | |||
| continue; | |||
| } | |||
|
|
|||
| // Compute the version from the source file content | |||
| const version: string = sourceFile.version || ''; | |||
| // Typescript only computes the version during an incremental build. | |||
There was a problem hiding this comment.
Suggested change
| // Typescript only computes the version during an incremental build. | |
| // TypeScript only computes the version during an incremental build. |
Comment on lines
+179
to
+186
| const transformedLintResults: TEslint.ESLint.LintResult[] = []; | ||
| for (const lintResult of lintResults) { | ||
| if (lintResult.messages.length > 0 || lintResult.warningCount > 0 || lintResult.errorCount > 0) { | ||
| transformedLintResults.push(lintResult); | ||
| } | ||
| } | ||
|
|
||
| return transformedLintResults; |
There was a problem hiding this comment.
Suggested change
| const transformedLintResults: TEslint.ESLint.LintResult[] = []; | |
| for (const lintResult of lintResults) { | |
| if (lintResult.messages.length > 0 || lintResult.warningCount > 0 || lintResult.errorCount > 0) { | |
| transformedLintResults.push(lintResult); | |
| } | |
| } | |
| return transformedLintResults; | |
| const trimmedLintResults: TEslint.ESLint.LintResult[] = []; | |
| for (const lintResult of lintResults) { | |
| if (lintResult.messages.length > 0 || lintResult.warningCount > 0 || lintResult.errorCount > 0) { | |
| trimmedLintResults.push(lintResult); | |
| } | |
| } | |
| return trimmedLintResults; |
| @@ -176,7 +176,14 @@ export class Eslint extends LinterBase<TEslint.ESLint.LintResult> { | |||
| return lintResult.fixableErrorCount + lintResult.fixableWarningCount > 0; | |||
| })); | |||
|
|
|||
| return lintResults; | |||
| const transformedLintResults: TEslint.ESLint.LintResult[] = []; | |||
There was a problem hiding this comment.
This change seems unrelated to the caching issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
context: https://rushstack.zulipchat.com/#narrow/channel/262522-heft/topic/heft-lint-plugin.20blocking/near/499305386
It looks like the ESLint part of the heft-lint-plugin hasn't been caching correctly. This should significantly speed up rebuilds with the cache still set up.
Details
How it was tested
Tested against
rush-lib, with a cache file the build time was ~2.2s and without the cache file it was ~7s. Before this change, it was a consistent 7s. Also verified that the cache file now has content.