Adding Oracle Database Vector Store Connector #327

psilberk · 2025-07-08T18:10:27Z

Motivation and Context

Addressing #321

Why is this change required?: adding Oracle implementation.
What problem does it solve?: NA
What scenario does it contribute to?: NA
If it fixes an open issue, please link to the issue here.

Description

We added the Oracle implementation. Following the similar approach of other vendors.

Contribution Checklist

[ X] The code builds clean without any errors or warnings
[ X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ X] All unit tests pass, and I have added new tests where possible
[ X] I didn't break anyone 😄

Split data module

Pom and demos1

Sample wip #2

Remove old implementation

…ssible.

…e-store-tests

…tel.java

…-oracle-store

…ic-kernel-java into add-oracle-store

Code clean-up, copyright and license.

Copyright and license

johnoliver · 2025-07-09T12:56:41Z

...rc/main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreFieldHelper.java

+     *
+     * @return the mapping between the supported Java key types and the Oracle database type.
+     */
+    public static HashMap<Class<?>, String> getSupportedKeyTypes() {


I would return an unmodifiable Map<Class<?>, String> if possible

johnoliver · 2025-07-09T12:58:03Z

...rc/main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreFieldHelper.java

+     * @return the mapping between the supported Java data types and the Oracle database type.
+     */
+    public static Map<Class<?>, String> getSupportedVectorTypes() {
+        return supportedVectorTypes;


make unmodifiable

johnoliver · 2025-07-09T12:59:57Z

...rc/main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreFieldHelper.java

+     */
+    public static String getCreateVectorIndexStatement(VectorStoreRecordVectorField field, String collectionTableName) {
+        switch (field.getIndexKind()) {
+            case IVFFLAT:


worth adding name checks to make sure we have no sql injections?

johnoliver · 2025-07-09T13:06:09Z

.../main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreQueryProvider.java

+                .getField(options.getVectorFieldName());
+        DistanceFunction distanceFunction = vectorField == null ? null : vectorField.getDistanceFunction();
+        if (options.getVectorFieldName() != null && vectorField == null) {
+            throw new SKException("");


Would be more descriptive here

johnoliver · 2025-07-09T13:10:01Z

...c/main/java/com/microsoft/semantickernel/data/jdbc/oracle/OracleVectorStoreRecordMapper.java

+            }
+
+            return new OracleVectorStoreRecordMapper<>(
+                (resultSet, options) -> {


I would pull this out into its own method, a very large lambda

johnoliver · 2025-07-09T13:16:16Z

pom.xml

@@ -71,13 +71,24 @@
        <module>semantickernel-bom</module>
        <module>semantickernel-api</module>
        <module>semantickernel-experimental</module>
+        <module>samples</module>


We only add samples to build in the with-samples maven profile, since the samples require a higher version of Java

Addressed in latest commit.

johnoliver · 2025-07-09T13:17:03Z

samples/semantickernel-concepts/semantickernel-syntax-examples/pom.xml

+        <dependency>
+            <groupId>com.microsoft.semantic-kernel</groupId>
+            <artifactId>semantickernel-data-jdbc</artifactId>
+            <version>1.4.4-SNAPSHOT</version>


should these be ${project.version} ?

Addressed in latest commit.

johnoliver · 2025-07-09T13:21:07Z

semantickernel-api-builders/pom.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>


This does proliferate the number of maven modules we publish to create a single class module, is there some dependency restriction that requires this module?

johnoliver · 2025-07-09T13:21:41Z

semantickernel-api-data/pom.xml

+        <dependency>
+            <groupId>io.projectreactor</groupId>
+            <artifactId>reactor-core</artifactId>
+            <version>3.4.38</version>


do we need to specify this version, is it not already defined?

Yes, we need to define it:
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for io.projectreactor:reactor-core:jar is missing. @ line 41, column 21

johnoliver · 2025-07-09T13:23:35Z

.../com/microsoft/semantickernel/data/vectorstorage/definition/VectorStoreRecordDefinition.java

@@ -193,7 +194,7 @@ public static VectorStoreRecordDefinition fromRecordClass(Class<?> recordClass)
                dataFields.add(VectorStoreRecordDataField.builder()
                    .withName(field.getName())
                    .withStorageName(storageName)
-                    .withFieldType(field.getType())
+                    .withFieldType(field.getType(),  List.class.equals(field.getType()) ? (Class<?>)((ParameterizedType) field.getGenericType()).getActualTypeArguments()[0] : null)


should this be List.class.isInstance?

jeandelavarene · 2025-07-09T16:13:06Z

data/semantickernel-data-oracle/pom.xml

+    </parent>
+
+    <artifactId>semantickernel-data-oracle</artifactId>
+    <name>Semantic Kernel Oracle connector</name>


Please add version 0.0.1 and indicate that this is a preview version.

psilberk · 2025-07-09T21:48:30Z

Hi, I’m not sure what is the information being requested. The code we are adding includes my name, company name, copyright and the license under which we are contributing the code. Pablo From: microsoft-github-policy-service[bot] ***@***.***> Date: Wednesday, July 9, 2025 at 2:42 PM To: microsoft/semantic-kernel-java ***@***.***> Cc: Pablo Silberkasten ***@***.***>, Mention ***@***.***> Subject: [External] : Re: [microsoft/semantic-kernel-java] Adding Oracle Database Vector Store Connector (PR #327) [https://avatars.githubusercontent.com/in/95686?s=20&v=4]microsoft-github-policy-service[bot] left a comment (microsoft/semantic-kernel-java#327)<https://urldefense.com/v3/__https:/github.com/microsoft/semantic-kernel-java/pull/327*issuecomment-3054162160__;Iw!!ACWV5N9M2RV99hQ!PCtmGe42xmlP4dm1ZC5To8mbg1EFVzRoEWQIWqnhXyss3lT9SShUHbsBZTzr1plZ_0_l5QlxvNIqYgvSzQF_ZCQ0cSVOKK8$> @psilberk<https://urldefense.com/v3/__https:/github.com/psilberk__;!!ACWV5N9M2RV99hQ!PCtmGe42xmlP4dm1ZC5To8mbg1EFVzRoEWQIWqnhXyss3lT9SShUHbsBZTzr1plZ_0_l5QlxvNIqYgvSzQF_ZCQ0Lkw6wJA$> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: * (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree * (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org<https://urldefense.com/v3/__http:/www.opensource.org__;!!ACWV5N9M2RV99hQ!PCtmGe42xmlP4dm1ZC5To8mbg1EFVzRoEWQIWqnhXyss3lT9SShUHbsBZTzr1plZ_0_l5QlxvNIqYgvSzQF_ZCQ0lRxja3I$>). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions. 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. Licenses. * Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. * Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. * Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/microsoft/semantic-kernel-java/pull/327*issuecomment-3054162160__;Iw!!ACWV5N9M2RV99hQ!PCtmGe42xmlP4dm1ZC5To8mbg1EFVzRoEWQIWqnhXyss3lT9SShUHbsBZTzr1plZ_0_l5QlxvNIqYgvSzQF_ZCQ0cSVOKK8$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ALJFHMP3PV2CCKMRFTZUTBT3HWECTAVCNFSM6AAAAACBB5PANOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJUGE3DEMJWGA__;!!ACWV5N9M2RV99hQ!PCtmGe42xmlP4dm1ZC5To8mbg1EFVzRoEWQIWqnhXyss3lT9SShUHbsBZTzr1plZ_0_l5QlxvNIqYgvSzQF_ZCQ0QrFFPq0$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

microsoft-github-policy-service · 2025-07-09T21:50:38Z

@psilberk the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

psilberk and others added 30 commits April 22, 2025 09:33

Adding Oracle Vector Store

bc2c366

Upsert and Main sample

ba1aa96

Split out the data into its own module

7d476fc

Removed dependencies

bf0c167

Merge branch 'microsoft:main' into main

9a7c650

Merge pull request #1 from fmeheust/split-data-module

a643fe2

Split data module

Added oracle store

376d8d2

Added Oracle store

458ace8

Added reference to parent's pom in sqlite

8bef1ff

Any tag filter

a514b28

Clean pom and 1st Sample

d8b6895

Merge branch 'main' into pom_and_demos1

e3ea6a2

Merge pull request #2 from psilberk/pom_and_demos1

e5e4ae3

Pom and demos1

Sample wip #2

df07b40

Merge pull request #3 from psilberk/pom_and_demos1

f0099cf

Sample wip #2

Add test for IndexKind.UNDEFINED and IndexKind.HNSW

805f5fa

Remove old implementation

1ca9439

Merge pull request #4 from psilberk/pom_and_demos1

92339ab

Remove old implementation

Added constants for type mapping and matched ODP type mapping when po…

c3bfafb

…ssible.

Adding Book class and pom fixes

bc0f640

Missing getter methods and wrong null check

3cbee72

Merge remote-tracking branch 'origin/add-oracle-store' into add-oracl…

03456d1

…e-store-tests

add test for key type

c3db036

enable test for COSINE_DISTANCE, COSINE_SIMILARITY, DOT_PRODUCT in Ho…

2306e21

…tel.java

Refactoring

0bf9199

Add test for supported data type(timestamp and uuid not included)

434b9e6

Merge remote-tracking branch 'origin/add-oracle-store-tests' into add…

89bc5ea

…-oracle-store

Test and bug fixes

1c83d62

BigDecimal mapping and value range

a6fac68

Any tag filter

2f421a8

fmeheust and others added 15 commits June 26, 2025 19:24

Merge branch 'main' into add-oracle-store

9eaad94

Fixed merge issues

abd6d42

add extended test

219a4d8

resolve conflict of git rebase

756e1ad

Changes after Michael's code review

578c733

add more test to extended test

dd6be5e

Set search vector as array of float[] insteand of List as string

f5c9cfa

Merge branch 'add-oracle-store' of https://github.com/psilberk/semant…

d20908a

…ic-kernel-java into add-oracle-store

Merge pull request #7 from psilberk/add-oracle-store

d6f63a5

Code clean-up, copyright and license.

Clean up and remove deps from pom

2a8d372

Remove unused imports

c793b82

Copyright and license

3b299ee

Samples

632e388

Merge pull request #8 from psilberk/copyright-and-license

9662092

Copyright and license

Merge branch 'microsoft:main' into main

129ad0d

karianna requested a review from johnoliver July 8, 2025 23:20

johnoliver reviewed Jul 9, 2025

View reviewed changes

jeandelavarene reviewed Jul 9, 2025

View reviewed changes

Addressing review comments

68f7914

Adding Oracle Database Vector Store Connector #327

Are you sure you want to change the base?

Adding Oracle Database Vector Store Connector #327

Uh oh!

Conversation

psilberk commented Jul 8, 2025

Motivation and Context

Description

Contribution Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psilberk commented Jul 9, 2025 via email

Uh oh!

microsoft-github-policy-service bot commented Jul 9, 2025

Uh oh!

Uh oh!