Fix top navigation Public Workspace crash - #1243
Merged
Paul Lizer (paullizer) merged 2 commits intoAug 14, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve the application version conflict at 0.250.196 while preserving the upstream 0.250.195 changes and top-navigation regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_workspace_labelsbefore the top navigation renders, preventing the JinjaUndefinedErrortriggered by a savednavLayout: "top"preference when Public Workspaces is enabled.Development, resolve the application version at0.250.196, and add fix documentation and release notes.Validation
python functional_tests/test_public_workspace_display_name_settings.py(4/4 passed)python functional_tests/test_admin_settings_sidebar_card_parity.py(4/4 passed after mergingDevelopment)python -m py_compile functional_tests/test_public_workspace_display_name_settings.py ui_tests/test_chat_sidebar_toggle_controls.py functional_tests/test_admin_settings_sidebar_card_parity.py ui_tests/test_admin_settings_sidebar_card_navigation.pygit -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check