Harden tabular analysis and public workspace chat grounding - #1246
Merged
Paul Lizer (paullizer) merged 2 commits intoAug 14, 2026
Merged
Conversation
…by default Customer prompt phrased with 'line' instead of 'row' (for each line in this document... go line by line) never triggered the durable tabular Analyze/Search pipeline for either mode, falling back to the old bounded foreground TabularProcessingPlugin tool loop and truncating after ~7 of 200 rows. Two independent root causes: (1) at least 8 duplicated exhaustive/per-row keyword-list detection functions across functions_tabular_orchestration.py, functions_tabular_parity_contract.py, route_backend_chats.py, and functions_document_analysis.py recognized row phrasing but never line phrasing; (2) enable_tabular_hierarchical_analysis (a backend-only setting with no admin UI) defaulted to False, blocking narrative per-row/per-line requests from ever reaching the durable hierarchical_analysis task type regardless of intent detection. Added line-phrase variants to every affected keyword list, flipped enable_tabular_hierarchical_analysis to active by default, and extended the existing emergency env kill switch to cover it. Verified end-to-end for both analyze and search action modes using the exact customer prompt. New test: test_tabular_line_terminology_routing_fix.py (3/3). Re-ran ~16 related suites plus the full scale-matrix with no regressions. Version 0.250.196 -> 0.250.197.
Complete durable tabular artifact publication and recovery, migrate stale parity settings, and align Search/Analyze output contracts. Make hidden public workspaces visible when users explicitly hand documents off to Chat while preserving existing visibility choices. Refs #1245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIMPLECHAT_DISABLE_TABULAR_PARITY_DURABLE_PREFLIGHTas the emergency rollback switch.User Impact
Validation
test_document_analysis_lossless_artifacts.py: 7/7test_tabular_analyze_shared_preflight_adapter.py: 6/6test_tabular_line_terminology_routing_fix.py: 3/3test_tabular_phase8_ui_telemetry_rollout.py: passedtest_tabular_row_orchestration_scale.py: passed, including 100,000-row planning and publication contractstest_tabular_durable_artifact_lifecycle_recovery.py: 5/5test_tabular_parity_stale_settings_migration.py: 6/6test_tabular_search_analyze_artifact_matrix.py: passedtest_public_workspace_hidden_document_chat_visibility.py: 5/5ui_tests/test_chat_background_generated_export_status.py: 6 passed, 4 environment-dependent skips.py_compile, staged whitespace checks, and untracked-file formatting checks were clean.Risk And Rollback
Documentation
v0.250.200.Fixes #1245