Fix skills grid cropping when filtered list has 5–8 items#103
Merged
Fix skills grid cropping when filtered list has 5–8 items#103
Conversation
Only apply maxHeight constraint when filteredSkills.length > MAX_VISIBLE_COLLAPSED. When there are fewer skills than the collapsed limit, all items display naturally without height restriction, preventing the previous bug where cards were cropped with no way to expand them. Co-authored-by: thegovind <18152044+thegovind@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug with skills list show more button in GitHub Pages
Fix skills grid cropping when filtered list has 5–8 items
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxHeightis unconditionally applied to the skills grid when collapsed, but the "Show More" button and fade gradient only render whenfilteredSkills.length > MAX_VISIBLE_COLLAPSED(8). Result: 5–8 skills get clipped with no way to expand.maxHeightwhen all items fit within the collapsed row limitBefore
Cards cropped with no Show More button (e.g. Communication category, 5 skills):
After
All cards fully visible when ≤ 8 skills shown; Show More still works for 9+:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/skills/skills/docs-site/node_modules/.bin/astro build(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/skills/skills/docs-site/node_modules/.bin/astro preview --port 4321(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.