Skip to content

Fix skills grid cropping when filtered list has 5–8 items#103

Merged
thegovind merged 2 commits intomainfrom
copilot/fix-skills-list-show-more-button
Feb 6, 2026
Merged

Fix skills grid cropping when filtered list has 5–8 items#103
thegovind merged 2 commits intomainfrom
copilot/fix-skills-list-show-more-button

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

maxHeight is unconditionally applied to the skills grid when collapsed, but the "Show More" button and fade gradient only render when filteredSkills.length > MAX_VISIBLE_COLLAPSED (8). Result: 5–8 skills get clipped with no way to expand.

  • Skip maxHeight when all items fit within the collapsed row limit
- maxHeight: isExpanded ? 'none' : 'calc((180px + var(--space-lg)) * 2)',
+ maxHeight: isExpanded || filteredSkills.length <= MAX_VISIBLE_COLLAPSED ? 'none' : 'calc((180px + var(--space-lg)) * 2)',

Before

Cards cropped with no Show More button (e.g. Communication category, 5 skills):

before

After

All cards fully visible when ≤ 8 skills shown; Show More still works for 9+:

after

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/skills/skills/docs-site/node_modules/.bin/astro build (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/skills/skills/docs-site/node_modules/.bin/astro preview --port 4321 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Only apply maxHeight constraint when filteredSkills.length > MAX_VISIBLE_COLLAPSED.
When there are fewer skills than the collapsed limit, all items display naturally
without height restriction, preventing the previous bug where cards were cropped
with no way to expand them.

Co-authored-by: thegovind <18152044+thegovind@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix bug with skills list show more button in GitHub Pages Fix skills grid cropping when filtered list has 5–8 items Feb 6, 2026
Copilot AI requested a review from thegovind February 6, 2026 04:06
@thegovind thegovind marked this pull request as ready for review February 6, 2026 04:11
@thegovind thegovind merged commit bcfcbf9 into main Feb 6, 2026
2 checks passed
@thegovind thegovind deleted the copilot/fix-skills-list-show-more-button branch February 6, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants