Skip to content

Conversation

@heyitsaamir
Copy link
Collaborator

@heyitsaamir heyitsaamir commented May 15, 2025

Summary of PR

  • Adds better granular control over different types of storages
  • Splits up memory and message storage
  • Adds support for azure ai search.

Details

Testing

Tested locally.

Checklist

  • I thought through documentation (and updated the docs if necessary)
  • I updated the CHANGELOG.md file (or have a good reason not to)

Copilot AI review requested due to automatic review settings May 15, 2025 22:46
@heyitsaamir heyitsaamir requested a review from a team as a code owner May 15, 2025 22:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the storage configurations for the memory module to use specific storage classes (e.g. SQLiteStorageConfig and AzureAISearchStorageConfig) and adjusts the associated module implementations accordingly. Key changes include refactoring imports and type checks in various evaluation scripts and storage modules, adding support for Azure AI Search in a new storage class, and updating configuration validation in MemoryModuleConfig.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/evaluate_qa.py, scripts/evaluate_memory_decisions.py, scripts/evaluate_extraction.py Updated storage configuration imports to use SQLiteStorageConfig
packages/teams_memory/storage/* Replaced StorageConfig with SQLiteStorageConfig in multiple storage modules
packages/teams_memory/storage/azure_ai_search.py Added new storage implementation leveraging Azure AI Search
packages/teams_memory/core/memory_core.py Refactored memory and message storage handling with updated config and type changes
packages/teams_memory/config.py, README.md, pyproject.toml, packages/evals/* Updated documentation, configuration defaults, dependencies, and benchmark references

@heyitsaamir heyitsaamir changed the title Aamirj/azure ai search Add azure ai search May 16, 2025
@heyitsaamir heyitsaamir merged commit 6c36f71 into main May 16, 2025
3 of 4 checks passed
@heyitsaamir heyitsaamir deleted the aamirj/azureAiSearch branch May 16, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants