Update samples to minimal apis #220

rido-min · 2025-12-04T15:40:24Z

This pull request refactors the startup and controller logic for the BotBuilder and Cards samples to use a more modern, streamlined approach based on inline lambda handlers instead of annotated controller classes. It also simplifies the structure and improves clarity in both message and card handling, and updates card creation methods for consistency and brevity.

Refactoring to Lambda-based Handlers:

Replaces annotated controller classes and methods with inline lambda handlers for both message and adaptive card actions, using the teams.OnMessage and teams.OnAdaptiveCardAction APIs in Program.cs. This makes the code more idiomatic and easier to follow for modern ASP.NET Core applications. [1] [2] [3]

Message and Card Handling Improvements:

Refactors message handling to use context.Send and context.Log directly, improving readability and consistency. Also, adds a SanitizeForLog helper for safer logging of user input.
Refactors adaptive card action handling to use context.Send and context.Log, and simplifies the response logic for various actions. [1] [2]

Card Creation Method Updates:

Updates all adaptive card creation methods to use static methods and the Microsoft.Teams.Cards.AdaptiveCard type directly, and simplifies the initialization of card elements for better readability and maintainability. [1] [2] [3] [4] [5] [6]

These changes modernize the sample apps, making them easier to understand and maintain, and align them with current best practices for ASP.NET Core and Teams development.

Co-authored-by: rido-min <[email protected]>

Copilot

Pull request overview

This pull request modernizes the sample applications by migrating from a controller-based architecture with attribute annotations to a minimal API pattern using inline lambda handlers. The refactoring significantly simplifies the code structure and aligns with modern ASP.NET Core best practices.

Key Changes:

Replaces [TeamsController] classes and attribute-based methods ([Message], [AdaptiveCard.Action], etc.) with lambda-based event handlers registered directly on the teams object
Consolidates context access by using context.Send(), context.Typing(), and context.Log directly instead of injected IContext.Client and ILogger parameters
Adds consistent SanitizeForLog() helper function across samples to prevent log injection vulnerabilities

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Samples/Samples.MessageExtensions/Program.cs	Refactored to top-level statements with inline lambda handlers for all message extension events (OnQuery, OnSubmitAction, OnQueryLink, OnSelectItem, OnQuerySettingsUrl, OnFetchTask, OnSetting). Removed Controller class and annotations.
Samples/Samples.Lights/Program.cs	Removed Controller class and migrated to lambda-based OnMessage handlers for "/history" command and default message processing. Directly accesses prompt factory from services.
Samples/Samples.Echo/Program.cs	Simplified from class-based structure to minimal API with OnActivity and OnMessage lambda handlers. Removed OpenAPI configuration and event handling.
Samples/Samples.Dialogs/Program.cs	Converted dialog handling from Controller methods to lambda-based OnMessage, OnTaskFetch, and OnTaskSubmit handlers. All helper methods converted to static local functions.
Samples/Samples.Cards/Program.cs	Migrated card handling from Controller class to OnMessage and OnAdaptiveCardAction lambda handlers. All card creation methods converted to static local functions.
Samples/Samples.BotBuilder/Program.cs	Simplified BotBuilder integration to use lambda-based OnMessage handler instead of Controller class with attributes.
Samples/Samples.Lights/Controller.cs	Deleted - functionality moved to Program.cs lambda handlers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T15:58:50Z

Samples/Samples.Lights/Program.cs

+    await prompt.Send(context.Activity.Text, new() { Messages = state.Messages }, (chunk) => Task.Run(() =>
+    {
+        context.Stream.Emit(chunk);
+    }), context.CancellationToken);


The use of Task.Run(() => { context.Stream.Emit(chunk); }) unnecessarily queues work to the thread pool. Since context.Stream.Emit(chunk) is likely a synchronous operation, the lambda can be simplified to (chunk) => { context.Stream.Emit(chunk); return Task.CompletedTask; } or just use a synchronous Action if the API supports it, avoiding the overhead of Task.Run.

Suggested change

await prompt.Send(context.Activity.Text, new() { Messages = state.Messages }, (chunk) => Task.Run(() =>

{

context.Stream.Emit(chunk);

}), context.CancellationToken);

await prompt.Send(context.Activity.Text, new() { Messages = state.Messages }, (chunk) => { context.Stream.Emit(chunk); return Task.CompletedTask; }, context.CancellationToken);

@aacebo is there any reason to use Task.Run here? wondering if we can omit this suggestion

Samples/Samples.Dialogs/Program.cs

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-15T21:54:38Z

Samples/Samples.Dialogs/Program.cs

+    var serializedCard = JsonSerializer.Serialize(card, new JsonSerializerOptions { WriteIndented = true, DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull });
+    Console.WriteLine($"[DEBUG] Launcher Card JSON: {serializedCard}");

-            return new Microsoft.Teams.Api.TaskModules.Response(new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo));
-        }
+    return card;
+}

-        private static Microsoft.Teams.Api.TaskModules.Response CreateMultiStepFormDialog()
-        {
-            var cardJson = """
-            {
-                "type": "AdaptiveCard",
-                "version": "1.4",
-                "body": [
-                    {
-                        "type": "TextBlock", 
-                        "text": "This is a multi-step form", 
-                        "size": "Large", 
-                        "weight": "Bolder"
-                    },
-                    {
-                        "type": "Input.Text",
-                        "id": "name",
-                        "label": "Name",
-                        "placeholder": "Enter your name",
-                        "isRequired": true
-                    }
-                ],
-                "actions": [
-                    {
-                        "type": "Action.Submit", 
-                        "title": "Submit", 
-                        "data": {"submissiondialogtype": "webpage_dialog_step_1"}
-                    }
-                ]
-            }
-            """;
+static Microsoft.Teams.Api.TaskModules.Response CreateSimpleFormDialog()
+{
+    var cardJson = """
+    {
+        "type": "AdaptiveCard",
+        "version": "1.4",
+        "body": [
+            { "type": "TextBlock", "text": "This is a simple form", "size": "Large", "weight": "Bolder" },
+            { "type": "Input.Text", "id": "name", "label": "Name", "placeholder": "Enter your name", "isRequired": true }
+        ],
+        "actions": [{"type": "Action.Submit", "title": "Submit", "data": {"submissiondialogtype": "simple_form"}}]
+    }
+    """;

-            var dialogCard = JsonSerializer.Deserialize<Microsoft.Teams.Cards.AdaptiveCard>(cardJson)
-                ?? throw new InvalidOperationException("Failed to deserialize multi-step form card");
+    var dialogCard = JsonSerializer.Deserialize<Microsoft.Teams.Cards.AdaptiveCard>(cardJson)
+        ?? throw new InvalidOperationException("Failed to deserialize simple form card");

-            var taskInfo = new Microsoft.Teams.Api.TaskModules.TaskInfo
-            {
-                Title = "Multi-step Form Dialog",
-                Card = new Microsoft.Teams.Api.Attachment
-                {
-                    ContentType = new Microsoft.Teams.Api.ContentType("application/vnd.microsoft.card.adaptive"),
-                    Content = dialogCard
-                }
-            };
+    var serializedCard = JsonSerializer.Serialize(dialogCard);
+    Console.WriteLine($"[DEBUG] Simple Form Card JSON: {serializedCard}");

-            return new Microsoft.Teams.Api.TaskModules.Response(new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo));
+    var taskInfo = new Microsoft.Teams.Api.TaskModules.TaskInfo
+    {
+        Title = "Simple Form Dialog",
+        Card = new Microsoft.Teams.Api.Attachment
+        {
+            ContentType = new Microsoft.Teams.Api.ContentType("application/vnd.microsoft.card.adaptive"),
+            Content = dialogCard
        }
+    };

-        private static Microsoft.Teams.Api.TaskModules.Response CreateMixedExampleDialog()
-        {
-            var taskInfo = new Microsoft.Teams.Api.TaskModules.TaskInfo
-            {
-                Title = "Mixed Example (C# Sample)",
-                Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(800),
-                Height = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(600),
-                Url = "https://teams.microsoft.com/l/task/example-mixed"
-            };
+    var continueTask = new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo);

-            return new Microsoft.Teams.Api.TaskModules.Response(new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo));
-        }
+    Console.WriteLine($"[DEBUG] continueTask.Value is null: {continueTask.Value == null}");
+    Console.WriteLine($"[DEBUG] continueTask.Value.Title: '{continueTask.Value?.Title}'");
+    Console.WriteLine($"[DEBUG] continueTask.Value.Card is null: {continueTask.Value?.Card == null}");
+
+    var debugOptions = new JsonSerializerOptions
+    {
+        DefaultIgnoreCondition = JsonIgnoreCondition.Never,
+        WriteIndented = true
+    };
+    var continueTaskJson = JsonSerializer.Serialize(continueTask, debugOptions);
+    Console.WriteLine($"[DEBUG] ContinueTask JSON (no ignore): {continueTaskJson}");
+
+    var response = new Microsoft.Teams.Api.TaskModules.Response(continueTask);
+    var serializedResponse = JsonSerializer.Serialize(response, debugOptions);
+    Console.WriteLine($"[DEBUG] Response JSON (no ignore): {serializedResponse}");


Extensive debug logging (lines 191-243) using Console.WriteLine remains in the production code. Consider either removing these debug statements or converting them to use the proper logging framework (context.Log) with appropriate log levels, or wrap them in a conditional compilation directive for debug builds only.

Copilot · 2025-12-15T21:54:38Z

Samples/Samples.Cards/Program.cs

+    {
+        Console.WriteLine($"Error deserializing card JSON: {ex.Message}");


Debug logging using Console.WriteLine is still present in production code. For consistency with the logging framework used elsewhere in the sample, consider using context.Log instead of Console.WriteLine, or conditionally compile these debug statements.

Suggested change

{

Console.WriteLine($"Error deserializing card JSON: {ex.Message}");

{

#if DEBUG

Console.WriteLine($"Error deserializing card JSON: {ex.Message}");

#endif

Copilot · 2025-12-15T21:54:38Z

Samples/Samples.MessageExtensions/Program.cs

+            Height = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),
+            Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),


The Union type is used without a fully qualified name, but the using directive for Microsoft.Teams.Common was added at line 8. Verify that Union is accessible from this namespace - if not, the fully qualified name should be used as it was in the old code.

Suggested change

Height = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),

Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),

Height = new Microsoft.Teams.Common.Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),

Width = new Microsoft.Teams.Common.Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),

Copilot · 2025-12-15T21:54:39Z

Samples/Samples.Dialogs/Program.cs

+        Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(1000),
+        Height = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(800),
+        Url = $"{botEndpoint}/tabs/dialog-form"
+    };

-        private static string SanitizeForLog(string? input)
+    return new Microsoft.Teams.Api.TaskModules.Response(new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo));
+}
+
+static Microsoft.Teams.Api.TaskModules.Response CreateMultiStepFormDialog()
+{
+    var cardJson = """
+    {
+        "type": "AdaptiveCard",
+        "version": "1.4",
+        "body": [
+            { "type": "TextBlock", "text": "This is a multi-step form", "size": "Large", "weight": "Bolder" },
+            { "type": "Input.Text", "id": "name", "label": "Name", "placeholder": "Enter your name", "isRequired": true }
+        ],
+        "actions": [{ "type": "Action.Submit", "title": "Submit", "data": {"submissiondialogtype": "webpage_dialog_step_1"} }]
+    }
+    """;
+
+    var dialogCard = JsonSerializer.Deserialize<Microsoft.Teams.Cards.AdaptiveCard>(cardJson)
+        ?? throw new InvalidOperationException("Failed to deserialize multi-step form card");
+
+    var taskInfo = new Microsoft.Teams.Api.TaskModules.TaskInfo
+    {
+        Title = "Multi-step Form Dialog",
+        Card = new Microsoft.Teams.Api.Attachment
        {
-            if (input == null) return "";
-            return input.Replace("\r", "").Replace("\n", "");
+            ContentType = new Microsoft.Teams.Api.ContentType("application/vnd.microsoft.card.adaptive"),
+            Content = dialogCard
        }
-    }
-}
+    };
+
+    return new Microsoft.Teams.Api.TaskModules.Response(new Microsoft.Teams.Api.TaskModules.ContinueTask(taskInfo));
+}
+
+static Microsoft.Teams.Api.TaskModules.Response CreateMixedExampleDialog()
+{
+    var taskInfo = new Microsoft.Teams.Api.TaskModules.TaskInfo
+    {
+        Title = "Mixed Example (C# Sample)",
+        Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(800),


The Union type is used without a fully qualified name. Ensure that the Microsoft.Teams.Common namespace import at line 7 provides access to the Union type, otherwise this will cause a compilation error.

Copilot · 2025-12-15T21:54:39Z

Samples/Samples.MessageExtensions/Program.cs

+teams.OnQuery(context =>
+{
+    context.Log.Info("[MESSAGE_EXT_QUERY] Search query received");
+    var activity = context.Activity;
+    var commandId = activity.Value?.CommandId;
+    var query = activity.Value?.Parameters?.FirstOrDefault(p => p.Name == "searchQuery")?.Value?.ToString() ?? "";
+    context.Log.Info($"[MESSAGE_EXT_QUERY] Command: {commandId}, Query: {query}");

-        app.Run();
+    if (commandId == "searchQuery")
+    {
+        return Task.FromResult(CreateSearchResults(query, context.Log));
    }

-    [TeamsController]
-    public class Controller
+    return Task.FromResult(new Microsoft.Teams.Api.MessageExtensions.Response
    {
-        private readonly IConfiguration _configuration;
-
-        public Controller(IConfiguration configuration)
+        ComposeExtension = new Microsoft.Teams.Api.MessageExtensions.Result
        {
-            _configuration = configuration;
+            Type = Microsoft.Teams.Api.MessageExtensions.ResultType.Result,
+            AttachmentLayout = Microsoft.Teams.Api.Attachment.Layout.List,
+            Attachments = new List<Microsoft.Teams.Api.MessageExtensions.Attachment>()
        }
+    });


The OnQuery handler doesn't validate the commandId before the switch statement. If commandId is null or doesn't match "searchQuery", it returns an empty attachment list. Consider logging a warning for unknown commands to aid debugging, similar to how other handlers log their operations.

Copilot · 2025-12-15T21:54:39Z

Samples/Samples.MessageExtensions/Program.cs

+teams.OnFetchTask(context =>
+{
+    context.Log.Info("[MESSAGE_EXT_FETCH_TASK] Fetch task received");
+    var activity = context.Activity;
+    var commandId = activity.Value?.CommandId;
+    context.Log.Info($"[MESSAGE_EXT_FETCH_TASK] Command: {commandId}");
+    return Task.FromResult(CreateFetchTaskResponse(commandId, context.Log));
+});


The OnTaskFetch and other handler methods return Task.FromResult for synchronous operations. While this works, these handlers could be made synchronous by changing the handler signature or by making the lambda non-async if the Teams API supports it. This would be more idiomatic and slightly more efficient.

Copilot · 2025-12-15T21:54:39Z

Samples/Samples.BotBuilder/Program.cs

 using Microsoft.Teams.Plugins.AspNetCore.Extensions;

-namespace Samples.BotBuilder;
+using Samples.BotBuilder;


The namespace directive was removed but the code references Samples.BotBuilder.Bot (via the using statement at line 7). Ensure that the Bot class is defined in the Samples.BotBuilder namespace in another file, otherwise this will cause a compilation error.

Copilot · 2025-12-15T21:54:40Z

Samples/Samples.Cards/Program.cs

+            break;
+
+        case "test_json":
+            await context.Send("JSON deserialization test successful!");


The JSON deserialization success message was changed from a more informative message that included emojis and detailed explanation to a simpler message. While this is more consistent with other success messages, it reduces clarity about what was successfully tested.

Suggested change

await context.Send("JSON deserialization test successful!");

await context.Send("✅ JSON deserialization test successful!\n\nThe card data was successfully deserialized from JSON and processed by the bot. If you see this message, your JSON payload was parsed correctly! 🎉");

Copilot · 2025-12-15T21:54:40Z

Samples/Samples.Dialogs/Program.cs

+    var botEndpoint = configuration["BotEndpoint"];
+    if (string.IsNullOrEmpty(botEndpoint))
+    {
+        log.Warn("No remote endpoint detected. Using webpages for dialog will not work as expected");


The fallback comment was removed. Consider adding a brief comment explaining that this is a fallback for local development when BotEndpoint is not configured, for better code documentation.

Suggested change

log.Warn("No remote endpoint detected. Using webpages for dialog will not work as expected");

log.Warn("No remote endpoint detected. Using webpages for dialog will not work as expected");

// Fallback for local development when BotEndpoint is not configured

Copilot AI and others added 5 commits December 4, 2025 14:33

Initial plan

15cd0a3

Migrate samples from controller pattern to minimal APIs

11bd990

Co-authored-by: rido-min <[email protected]>

Fix code review comments on MessageExtensions return types

3d74579

Co-authored-by: rido-min <[email protected]>

remove swagger from echo

6235af3

Merge branch 'main' into copilot/update-samples-to-minimal-apis

d460178

rido-min marked this pull request as ready for review December 4, 2025 15:55

Copilot AI review requested due to automatic review settings December 4, 2025 15:55

Copilot started reviewing on behalf of rido-min December 4, 2025 15:55 View session

Copilot finished reviewing on behalf of rido-min December 4, 2025 15:58

Copilot AI reviewed Dec 4, 2025

View reviewed changes

heyitsaamir approved these changes Dec 4, 2025

View reviewed changes

Merge branch 'main' into copilot/update-samples-to-minimal-apis

245e65a

rido-min marked this pull request as draft December 11, 2025 18:47

Merge branch 'main' into copilot/update-samples-to-minimal-apis

b87ed68

rido-min marked this pull request as ready for review December 15, 2025 21:48

Copilot AI review requested due to automatic review settings December 15, 2025 21:48

Copilot started reviewing on behalf of rido-min December 15, 2025 21:49 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

MehakBindra approved these changes Jan 5, 2026

View reviewed changes

Merge branch 'main' into copilot/update-samples-to-minimal-apis

e4060ec

rido-min merged commit 72dee09 into microsoft:main Jan 16, 2026
6 checks passed

		{
		Console.WriteLine($"Error deserializing card JSON: {ex.Message}");

		Height = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),
		Width = new Union<int, Microsoft.Teams.Api.TaskModules.Size>(Microsoft.Teams.Api.TaskModules.Size.Small),

	await context.Send("JSON deserialization test successful!");
	await context.Send("✅ JSON deserialization test successful!\n\nThe card data was successfully deserialized from JSON and processed by the bot. If you see this message, your JSON payload was parsed correctly! 🎉");

	log.Warn("No remote endpoint detected. Using webpages for dialog will not work as expected");
	log.Warn("No remote endpoint detected. Using webpages for dialog will not work as expected");
	// Fallback for local development when BotEndpoint is not configured

Update samples to minimal apis #220

Update samples to minimal apis #220

Uh oh!

Conversation

rido-min commented Dec 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

rido-min Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants