Skip to content

Fix DevTools not logging outgoing messages #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajan-chari wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix DevTools not logging outgoing messages #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3e146
Fix DevTools not logging outgoing messages (issue #154)
rajan-chari Jan 9, 2026
0491f37
Address PR feedback: Remove debug logging and use .Where() filtering
rajan-chari Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Libraries/Microsoft.Teams.Apps/AppEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ protected async Task OnErrorEvent(IPlugin sender, ErrorEvent @event, Cancellatio
}
}

foreach (var plugin in Plugins)
foreach (var plugin in Plugins.Where(p => !ReferenceEquals(sender, p)))
{
if (sender.Equals(plugin)) continue;
await plugin.OnError(this, sender, @event, cancellationToken);
}
}
Expand All @@ -44,9 +43,8 @@ protected async Task OnActivitySentEvent(ISenderPlugin sender, ActivitySentEvent
{
Logger.Debug(EventType.ActivitySent);

foreach (var plugin in Plugins)
foreach (var plugin in Plugins.Where(p => !ReferenceEquals(sender, p)))
{
if (sender.Equals(plugin)) continue;
await plugin.OnActivitySent(this, sender, @event, cancellationToken);
}
}
Expand All @@ -55,9 +53,8 @@ protected async Task OnActivityResponseEvent(ISenderPlugin sender, ActivityRespo
{
Logger.Debug(EventType.ActivityResponse);

foreach (var plugin in Plugins)
foreach (var plugin in Plugins.Where(p => !ReferenceEquals(sender, p)))
{
if (sender.Equals(plugin)) continue;
await plugin.OnActivityResponse(this, sender, @event, cancellationToken);
}
}
Expand Down
Loading