Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary [regression] Trap when trying to use background image alignment that is not centered #18479

Closed
Zeroes1 opened this issue Jan 30, 2025 · 3 comments · Fixed by #18481
Closed
Assignees
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Zeroes1
Copy link

Zeroes1 commented Jan 30, 2025

Windows Terminal version

1.23.10282.0

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

  1. Set use background image in default profile
  2. Try use any alignment background image that is not centered
    for example in settings.json:
    "backgroundImageAlignment": "bottomRight",

after we got exception...

100% reproduced.

Windows create crashdump.

Expected Behavior

under Canary build:
..
terminal-1.23.10151.0 - latest good

Actual Behavior

terminal-1.23.10221.0 - with trouble
terminal-1.23.10271.0 - with trouble
terminal-1.23.10282.0 - with trouble

@Zeroes1 Zeroes1 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 30, 2025
@Zeroes1
Copy link
Author

Zeroes1 commented Jan 30, 2025

ExceptionAddress: 00007ff9ddf0fc29 (Microsoft_Terminal_Settings_Editor!winrt::impl::consume_Windows_ApplicationModel_Resources_Core_IResourceCandidatewinrt::Windows::ApplicationModel::Resources::Core::IResourceCandidate::ValueAsString+0x000000000000002a)
ExceptionCode: c0000005 (Access violation)

STACK_TEXT:
Microsoft_Terminal_Settings_Editor!GetLibraryResourceString+0x159
Microsoft_Terminal_Settings_Editor!winrt::Microsoft::Terminal::Settings::Editor::implementation::AppearanceViewModel::BackgroundImageAlignmentCurrentValue+0x496
Microsoft_Terminal_Settings_Editor!winrt::impl::producewinrt::Microsoft::Terminal::Settings::Editor::implementation::AppearanceViewModel,winrt::Microsoft::Terminal::Settings::Editor::IAppearanceViewModel::get_BackgroundImageAlignmentCurrentValue+0x2a

@DHowett
Copy link
Member

DHowett commented Jan 30, 2025

@carlos-zamora this is in the new SUI a11y previews

@DHowett
Copy link
Member

DHowett commented Jan 30, 2025

@Zeroes1 Thank you so much for using Canary and filing these bugs on us. We are close to 1.23 release, so it is VERY HELPFUL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants