Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SUI crash when image alignment not centered #18481

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

carlos-zamora
Copy link
Member

ConvergedAlignment stores vertical alignment to 0xF0 and horizontal alignment to 0x0F. These were accidentally backwards!

Closes #18479

@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Jan 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 30, 2025
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jan 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label Jan 30, 2025
@carlos-zamora carlos-zamora merged commit 4da527c into main Jan 30, 2025
20 checks passed
@carlos-zamora carlos-zamora deleted the dev/cazamor/bugfix-bg-img-align branch January 30, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary [regression] Trap when trying to use background image alignment that is not centered
3 participants