-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce UIA movement/expansion by page #14179
base: main
Are you sure you want to change the base?
Conversation
What's left for me to do:
This will be done by Windows Terminal v1.18. Ideally, I could even get this in for v1.17, but I suspect between the time it takes to review this and the last minute work that keeps popping up, I think it's a safer bet to say this'll be in 1.18 for sure. CC @codeofdusk |
1cec5f1
to
f80a23c
Compare
Getting closer. Tests are written. Just need to resolve the last 13 failing tests. They all have to do with non-degenerate ranges (which, unfortunately, is a pretty bug number of scenarios). @codeofdusk feel free to get a copy of the current implementation. I'll probably be able to finish fixing this up on Monday though. Again, keep in mind, non-degenerate ranges are the ones that are returning unexpected results. So be wary of that if you're testing it out. |
Hello, @carlos-zamora whats the status on this? |
Summary of the Pull Request
This adds support for the "Page" text unit in UiaTextRange. In terminals, the viewport will be used as the size of a "page". This should feel natural since "page up" and "page down" have been supported for quite some time. By extension, "expanding" to the page should return the same as getting the visible range.
This includes more UIA Table Tests that were manually verified and constructed from direct testing with Microsoft Word.
PR Checklist
Detailed Description of the Pull Request / Additional comments
(Coming soon)
Validation Steps Performed
(Coming soon)