-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch context menu generation to use a flags enum of actions #15481
Open
DHowett
wants to merge
7
commits into
main
Choose a base branch
from
dev/duhowett/applicableactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit da1b24a88267f7a9dea829dfc83bc5c057f0b6e7)
(cherry picked from commit d9bc198826780316b7b2822137203200381bfb43)
(cherry picked from commit 7d25a9a0844cba8b822cc84e3ede08c0681c1766)
(cherry picked from commit 346b1ae6e67d16f230bec8d8d7107faf02253a3a)
a8ab99c
to
9096325
Compare
Is there a reason this is a draft? This seems fine to me? (I must have missed it when I went on paternity last year, then never saw it again) |
I swear I had a reason. Let me dig back in. |
I think the issue is that I hadn't moved Copy/Paste over to this model honestly |
carlos-zamora
approved these changes
Dec 5, 2024
lhecker
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a hundred bespoke WinRT methods to determine what context menu items to show is not scalable!
In the future, we can add...
I also moved ownership of knowing where the menu was opened to TermControl.
It could go down to Interactivity with some work.
It just felt wrong to have the Core remembering this user interaction state.
I also fixed some trivial resource duplication.