System menu for terminal shows up on wrong monitor #15657
Conversation
…halnpl/System_menu_for_Terminal_shows_up_on_wrong_monitor
…halnpl/System_menu_for_Terminal_shows_up_on_wrong_monitor
microsoft-github-policy-service
bot
added
Issue-Bug
zadjii-msft
changed the title
| { | ||
| _window->OpenSystemMenu(std::nullopt, std::nullopt); | ||
| const NonClientIslandWindow* nonClientWindow{ static_cast<NonClientIslandWindow*>(_window.get()) }; |
There was a problem hiding this comment.
What happens if the user doesn't have "Show tabs in titlebar" enabled? Won't this explode, since this won't be a NonClientIslandWindow?
There was a problem hiding this comment.
Didn't know about this case. Let me check and iterate. Thank you for your feedback.
| // - Gets the height of title bar in physical pixels. | ||
| // Return Value | ||
| // - The height of title bar in physical pixels. | ||
| [[nodiscard]] float NonClientIslandWindow::GetTitleBarPhysicalRenderHeight() const noexcept |
There was a problem hiding this comment.
It seems a little odd to me that we need to expose this, just so that the app host can ask us for it, then tell us to do something again.
Shouldn't IslandWindow::OpenSystemMenu be able to figure out on its own:
- if we're maximized
- if we should correct the menu position for the NCIW (maybe using some
protectedhelper)?
There was a problem hiding this comment.
It is a bit odd. Let me take another stab at it with the next iteration.
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
|
(I'm gonna mark this as a draft for now to clear it out of our todo list before 1.19. Feel free to loop back around on it whenever) |
Summary of the Pull Request
This Pull Request addresses issue #15421. The system menu opened on the incorrect monitor in a multi-monitor setup when the terminal was maximized.
References and Relevant Issues
Issue: #15421
Detailed Description of the Pull Request / Additional comments
The problem was due to the positioning calculations for the system menu not considering that maximized windows have borders that extend beyond the monitor. This also affected the terminal in the borderless fullscreen (F11) mode.
In this PR, I've updated the positioning calculations to correctly account for the extended borders of maximized windows, ensuring that the system menu appears in the correct location on all monitors and in all display states, including the borderless fullscreen mode.
Additionally, this PR introduces extensive error checking and logging, which will assist in identifying and addressing similar issues in the future.
https://devblogs.microsoft.com/oldnewthing/20150304-00/?p=44543
Validation Steps Performed
I've validated this fix manually under various scenarios, including different monitor configurations, placements, and display states. The system menu now consistently opens correctly in all tested cases.
TAEF tests runner, no change.
PR Checklist