WIP: Move timers from TermControl to Core/Interactivity #15969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR moves the blink and cursor timers down to Core (where it has unfettered access to everything it needs).
It also puts Core in charge of displaying the cursor when there is input, and managing the cursor's focus visibility.
It also means that Core no longer needs a "BlinkCursor" method?
This PR will allow us to remove the timer from the WPF layer as well.
This PR also moves the autoscroll timer down into ControlInteractivity (!)
which means that all interactivity consumers get it for free. That's RAD.
All the logic is the same.
I also took the opportunity to remove some silly parts of the ControlInteractivity API that supported this, like it needing to be told whether the pointer was pressed while it was inside the box and whether it is focused (???)
Now it darn well keeps track of those things itself.
TODO:
cursor ??? while splitting a bunch of panes all at once