-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Accessibility Insights' FastPass #16055
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (1)etstandard To accept ✔️ these unrecognized words as correct, run the following commands... in a clone of the [email protected]:microsoft/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/6385007194/attempts/1' Pattern suggestions ✂️ (1)You could add these patterns to .github/actions/spelling/patterns/e8709bfb6db774e61c6a85f5b99801672950c84c.txt:
Warnings (1)See the 📂 files view or the 📜action log for details.
See ℹ️ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a glutton for the pain of hand-editing .*proj
files, so these would otherwise just be nits on what is a solid PR that I'm super excited about
@@ -50,14 +50,56 @@ | |||
<Reference Include="appium-dotnet-driver, Version=3.0.0.2, Culture=neutral, processorArchitecture=MSIL"> | |||
<HintPath>$(AppiumWebDriverPathRoot)\lib\net45\appium-dotnet-driver.dll</HintPath> | |||
</Reference> | |||
<Reference Include="Axe.Windows.Actions, Version=2.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> | |||
<HintPath>..\..\..\packages\Axe.Windows.2.1.3\lib\netstandard20\Axe.Windows.Actions.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes, can we at the very least add path/to/packages\Axe.Windows.2.1.3
to src\common.nugetversions.props
, so that we can just do
<HintPath>$(AxeWindowsPathRoot)\lib\netstandard20\Axe.Windows.Actions.dll</HintPath>
?
<Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
<HintPath>$(NewtonsoftJSONPathRoot)\lib\net45\Newtonsoft.Json.dll</HintPath> | ||
<HintPath>..\..\..\packages\Newtonsoft.Json.13.0.3\lib\net45\Newtonsoft.Json.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert me pls
<Reference Include="Castle.Core, Version=4.1.1.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc, processorArchitecture=MSIL"> | ||
<HintPath>$(CastleCorePathRoot)\lib\net45\Castle.Core.dll</HintPath> | ||
</Reference> | ||
<Reference Include="Microsoft.Win32.Registry, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> | ||
<HintPath>..\..\..\packages\Microsoft.Win32.Registry.5.0.0\lib\net461\Microsoft.Win32.Registry.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar with the path to this package
</Reference> | ||
<Reference Include="System" /> | ||
<Reference Include="System.Drawing" /> | ||
<Reference Include="System.Drawing.Common, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL"> | ||
<HintPath>..\..\..\packages\System.Drawing.Common.7.0.0\lib\net462\System.Drawing.Common.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do all these System.*
packages need the full path too? That seems... wrong.
@@ -0,0 +1,10 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, did we really not have one of these for this project before? I feel like at least one of the existing packages.config
that we're using must have applied to this project, right?
either
packages\packages.config
dep\nuget\packages.config
and I forget what the difference is
Accessibility Insights has a neat tool called FastPass where it can scan the existing UI for common accessibility errors. FastPass is powered by Axe.Windows. This PR adds Axe.Windows to our project and adds a handful of accessibility tests to navigate the app (using WinAppDriver) then scan the UI using Axe.Windows.
Additionally, each error Axe.Windows finds is output to an a11ytest file that can be opened by Accessibility Insights to tell you what error was found and where the error is. These files are output to
\bin\x64\Debug\AxeWindowsOutputFiles\
There's a few tests that fail already. I've added comments explaining why they fail and saying that they are expected.