Move all blink handling into Renderer #19330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
lhecker
force-pushed
the
dev/lhecker/cursor-blinker
branch
from
4de989d to
8d17e85
Compare
lhecker
changed the base branch from
main
to
dev/lhecker/BEGONE-FOUL-SPIRIT
lhecker
force-pushed
the
dev/lhecker/cursor-blinker
branch
from
8d17e85 to
8390d60
Compare
DHowett
pushed a commit
that referenced
this pull request
Sep 22, 2025
Goal: Remove `CursorBlinker`. Problem: Spooky action at a distance via `Cursor::HasMoved`. Solution: Moved all the a11y event raising into `_stream.cpp` and pray for the best. Goal: Prevent node.js from tanking conhost performance via MSAA (WHY). Problem: `ServiceLocator`. Solution: Unserviced the locator. Debounced event raising. Performance increased by >10x. Problem 2: Lots of files changed. This PR is a prerequisite for #19330 ## Validation Steps Performed Ran NVDA with and without UIA enabled and with different delays. ✅
lhecker
force-pushed
the
dev/lhecker/cursor-blinker
branch
from
8390d60 to
5742c64
Compare
lhecker
changed the base branch from
dev/lhecker/BEGONE-FOUL-SPIRIT
to
main
lhecker
force-pushed
the
dev/lhecker/cursor-blinker
branch
from
5742c64 to
1c23430
Compare
DHowett
reviewed
Sep 26, 2025
| // - <none> | ||
| // Return Value: | ||
| // - <none> | ||
| void Window::_UpdateSystemMetrics() const |
There was a problem hiding this comment.
📝 Make sure nobody else called this who cares about the cursor metrics (probably not)
| cursor.SetSize(_d->ulSavedCursorSize); | ||
| cursor.SetIsVisible(_d->fSavedCursorVisible); | ||
| cursor.SetType(_d->savedCursorType); | ||
| cursor.SetIsOn(true); |
There was a problem hiding this comment.
📝 make sure selection has the same cursor behavior
| { | ||
| // Enter Mark Mode | ||
| // NOTE: directly set cursor state. We already should have locked before calling this function. | ||
| _activeBuffer().GetCursor().SetIsOn(false); |
There was a problem hiding this comment.
do we need to inhibit the cursor?
|
|
||
| void Terminal::BlinkCursor() noexcept | ||
| { | ||
| if (_selectionMode != SelectionInteractionMode::Mark) |
There was a problem hiding this comment.
do we need to inhibit the cursor for mark mode
There was a problem hiding this comment.
I just noticed that we let the cursor blink during selections. Why do we inhibit it for mark mode then, even though mark mode is essentially just keyboard-selection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is not quite finished (~90%?). Missing:
This PR moves the cursor blinker and VT blink rendition timer into
Renderer. To do so, this PR introduces a generic timer system with which you can schedule arbitrary timer jobs. Thanks to this, this PR removes a crapton of code, particularly throughout conhost, and improves throughput by another ~10%. On my PC it can now churn through >400MB/s while rendering at 240FPS. Fun fact: Processing 100kB of text and rendering it in conhost now takes less time than MSCTF (TSF) needs to process 1 keyboard character. When I look at our shell code.Validation Steps Performed