-
Notifications
You must be signed in to change notification settings - Fork 8.9k
docs(organization): remove non-existent files and fix case in Host File overview section #19487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…le Overview section
| * Main entry point used ONLY by the OS to send a pre-configured driver handle to conhostv2.dll | ||
| * `Main.cpp` | ||
| * `input.cpp` | ||
| * `inputkeyinfo.cpp` |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (2)inputkeyinfo These words are not needed and should be removedification Inputkeyinfo Inputreadhandledata Newdelete textinfo userprivapiTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:ansh1406/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.25/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/18684048515/attempts/1' &&
git commit -m 'Update check-spelling metadata'Warnings
|
| Count | |
|---|---|
| 1 |
See
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
- ... misspelled, then please correct them instead of using the command.
- ... names, please add them to
.github/actions/spelling/allow/names.txt. - ... APIs, you can add them to a file in
.github/actions/spelling/allow/. - ... just things you're using, please add them to an appropriate file in
.github/actions/spelling/expect/. - ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in
.github/actions/spelling/patterns/.
See the README.md in each directory for more information.
🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
| * `_output.cpp` | ||
| * `_stream.cpp` | ||
| * Handles copy/paste/etc. | ||
| * `clipboard.cpp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still exists.
| * Attempted class-ification of existing Cursor structures to take them out of Screen Info/Text Info | ||
| * `Cursor.cpp` | ||
| * Related to searching through the back buffer of the console (the output scroll buffer as defined in screeninfo/textinfo) | ||
| * `Find.cpp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
| * Contains global state data | ||
| * `Globals.cpp` | ||
| * Attempted class-ification of existing Icon manipulation to take them out of ConsoleInformation/Settings | ||
| * `Icon.cpp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
| * `Tracing.cpp` | ||
| * Private calls into the Windows Window Manager to perform privileged actions related to the console process (working to eliminate) or for High DPI stuff (also working to eliminate) | ||
| * `Userprivapi.cpp` | ||
| * `Windowdpiapi.cpp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
| * `Window.cpp` | ||
| * `Windowproc.cpp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't exist in src/host as mentioned in the file.
|
@microsoft-github-policy-service agree |
Summary of the Pull Request
The Host File Overview section in organization.md contained references to files that no longer exist in src/host.
Additionally, some filenames had incorrect casing. This PR removes the obsolete entries and corrects the filename cases for consistency.
References and Relevant Issues
Related to #18043
Validation Steps Performed
PR Checklist