Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple panes in the same window #825

Merged
merged 41 commits into from
Jun 7, 2019
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
606dd57
Start working on adding support for panes
zadjii-msft May 8, 2019
91dc273
Add basic pane splitting
zadjii-msft May 9, 2019
a600b20
This works for nesting panes
zadjii-msft May 9, 2019
faaba47
Switching tabs keeps focus on the last active pane now
zadjii-msft May 10, 2019
9b792d3
Reload settings for the panes.
zadjii-msft May 14, 2019
7ca3e8d
Get titles working again
zadjii-msft May 14, 2019
db7523a
Update the icon too
zadjii-msft May 14, 2019
7258a71
Pull these two guys into helpers
zadjii-msft May 14, 2019
29464ea
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 14, 2019
377aa4f
Hook up the terminal's closing to the pane's to the tab's
zadjii-msft May 14, 2019
23930b5
This is me trying to mess with the tab closing, but I think it's prob…
zadjii-msft May 14, 2019
a4fbc53
Revert "This is me trying to mess with the tab closing, but I think i…
zadjii-msft May 14, 2019
b353e89
TONS of polish. Doc comments, etc.
zadjii-msft May 14, 2019
dc3f522
Correctly close a pane when one of it's children has children
zadjii-msft May 15, 2019
d45a9aa
Correctly move focus to a child with children when the focused pane i…
zadjii-msft May 15, 2019
0a96ed4
doc comments for days
zadjii-msft May 15, 2019
a754474
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 17, 2019
ff21bd2
This is most all of the PR feedback
zadjii-msft May 17, 2019
ba805e8
Update doc/cascadia/Panes.md
zadjii-msft May 17, 2019
3d1c4ca
Mostly just PR nits
zadjii-msft May 20, 2019
013cefa
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 20, 2019
7c5c222
Fix some bugs with closing a leaf _after_ it was a parent.
zadjii-msft May 21, 2019
cd75b1d
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 21, 2019
d5060b3
Merge branch 'master' into dev/migrie/f/panes
zadjii-msft May 23, 2019
6d847dc
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 23, 2019
0f848e7
Remove the default keybinding.
zadjii-msft May 24, 2019
bbed9ed
switch to in-class initializers
zadjii-msft May 24, 2019
704f6cc
Update doc/cascadia/Panes.md
zadjii-msft May 30, 2019
d016d5c
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft May 30, 2019
40c5600
Apply suggestions from code review
zadjii-msft May 31, 2019
890fb3a
Add a NOTICES file.
DHowett May 31, 2019
0ea8b85
move the NOTICE to the right branch...
DHowett May 31, 2019
80036e2
Much of the easier PR feedback
zadjii-msft Jun 3, 2019
9165d02
Lock up the panes when they're getting opened/closed
zadjii-msft Jun 3, 2019
7f50a0f
A little bit of cleanup on the comments here
zadjii-msft Jun 3, 2019
b5d954e
Refactor the code for actually doing a split
zadjii-msft Jun 4, 2019
c6311f7
Clean up some typos
zadjii-msft Jun 7, 2019
a76db18
Merge remote-tracking branch 'origin/master' into dev/migrie/f/panes
zadjii-msft Jun 7, 2019
c265317
Fixed build error
carlos-zamora Jun 7, 2019
14f3ffa
Apply suggestions from code review
zadjii-msft Jun 7, 2019
f945c18
Apply suggestions from code review
zadjii-msft Jun 7, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
Let's try and write code in github
zadjii-msft authored Jun 7, 2019
commit f945c18ae2d9998be57959b9159ae6f088740815
4 changes: 2 additions & 2 deletions src/cascadia/TerminalApp/Tab.cpp
Original file line number Diff line number Diff line change
@@ -165,8 +165,8 @@ void Tab::SetTabText(const winrt::hstring& text)
{
// Copy the hstring, so we don't capture a dead reference
winrt::hstring textCopy{ text };
_tabViewItem.Dispatcher().RunAsync(CoreDispatcherPriority::Normal, [textCopy](){
_tabViewItem.Header(textCopy);
_tabViewItem.Dispatcher().RunAsync(CoreDispatcherPriority::Normal, [text = std::move(textCopy), this](){
_tabViewItem.Header(text);
});
}