Remove BinaryFormatter tests (#5097)

microsoft · Feb 21, 2025 · 6bf6651 · 6bf6651
1 parent 1466046
commit 6bf6651
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 69 deletions.
diff --git a/src/TestFramework/TestFramework/Exceptions/AssertFailedException.cs b/src/TestFramework/TestFramework/Exceptions/AssertFailedException.cs
@@ -51,5 +51,8 @@ public AssertFailedException()
     protected AssertFailedException(SerializationInfo info, StreamingContext context)
         : base(info, context)
     {
+        // Do not remove this as unused, it is used by BinaryFormatter when communicating between tested VisualStudio instance,
+        // and the UI testing framework that tests it. Don't attempt testing this in the repository using BinaryFormatter will trigger
+        // many compliance issues.
     }
 }
diff --git a/src/TestFramework/TestFramework/Exceptions/AssertInconclusiveException.cs b/src/TestFramework/TestFramework/Exceptions/AssertInconclusiveException.cs
@@ -51,5 +51,8 @@ public AssertInconclusiveException()
     protected AssertInconclusiveException(SerializationInfo info, StreamingContext context)
         : base(info, context)
     {
+        // Do not remove this as unused, it is used by BinaryFormatter when communicating between tested VisualStudio instance,
+        // and the UI testing framework that tests it. Don't attempt testing this in the repository using BinaryFormatter will trigger
+        // many compliance issues.
     }
 }
diff --git a/src/TestFramework/TestFramework/Exceptions/InternalTestFailureException.cs b/src/TestFramework/TestFramework/Exceptions/InternalTestFailureException.cs
@@ -62,5 +62,8 @@ public InternalTestFailureException()
     protected InternalTestFailureException(SerializationInfo info, StreamingContext context)
         : base(info, context)
     {
+        // Do not remove this as unused, it is used by BinaryFormatter when communicating between tested VisualStudio instance,
+        // and the UI testing framework that tests it. Don't attempt testing this in the repository using BinaryFormatter will trigger
+        // many compliance issues.
     }
 }
diff --git a/src/TestFramework/TestFramework/Exceptions/UnitTestAssertException.cs b/src/TestFramework/TestFramework/Exceptions/UnitTestAssertException.cs
@@ -50,5 +50,8 @@ protected UnitTestAssertException(string msg)
     protected UnitTestAssertException(SerializationInfo info, StreamingContext context)
         : base(info, context)
     {
+        // Do not remove this as unused, it is used by BinaryFormatter when communicating between tested VisualStudio instance,
+        // and the UI testing framework that tests it. Don't attempt testing this in the repository using BinaryFormatter will trigger
+        // many compliance issues.
     }
 }
diff --git a/...nitTests/TestFramework.UnitTests/Exceptions/BinaryFormatterExceptionSerializationTests.cs b/...nitTests/TestFramework.UnitTests/Exceptions/BinaryFormatterExceptionSerializationTests.cs