-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSTestAnalysisMode #4712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- TestFx.sln: Language not supported
- eng/verify-nupkgs.ps1: Language not supported
- src/Analyzers/MSTest.Analyzers.Package/MSTest.Analyzers.Package.csproj: Language not supported
- src/Analyzers/MSTest.Analyzers.Package/buildTransitive/MSTest.Analyzers.props: Language not supported
- src/Analyzers/MSTest.Analyzers.Package/buildTransitive/MSTest.Analyzers.targets: Language not supported
- src/Analyzers/MSTest.GlobalConfigsGenerator/MSTest.GlobalConfigsGenerator.csproj: Language not supported
Comments suppressed due to low confidence (4)
src/Analyzers/MSTest.GlobalConfigsGenerator/Program.cs:14
- Ensure that the behavior when the OUTPUT_PATH environment variable is not set is covered by tests.
string? outputPath = Environment.GetEnvironmentVariable("OUTPUT_PATH")
src/Analyzers/MSTest.GlobalConfigsGenerator/Program.cs:29
- Ensure that the severity comparison logic in the AppendRule method is covered by tests.
foreach (DiagnosticDescriptor rule in analyzers.SelectMany(analyzer => analyzer.SupportedDiagnostics).OrderBy(descriptor => descriptor.Id))
src/Analyzers/MSTest.GlobalConfigsGenerator/AnalyzerSeverityDecider.cs:69
- The error message could be more descriptive. Consider specifying which rule caused the issue.
throw new InvalidOperationException("Rules with severity >= Warning are expected to be enabled by default.");
src/Analyzers/MSTest.GlobalConfigsGenerator/AnalyzerSeverityDecider.cs:32
- [nitpick] The TODO comment should be addressed or tracked separately.
// TODO: We should consider at least not enabling "conflicting" rules.
src/Analyzers/MSTest.GlobalConfigsGenerator/AnalyzerSeverityDecider.cs
Outdated
Show resolved
Hide resolved
a812505
to
ed4b23f
Compare
…cider.cs Co-authored-by: Copilot <[email protected]>
src/Analyzers/MSTest.GlobalConfigsGenerator/AnalyzerSeverityDecider.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So glad to see this PR, you really rock @Youssef1313 🚀
Fixes #3325