fourslash baselines and VerifyBaselinefindAllReferences
#1274
+22,764
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fourslash-baseline
…o fourslash-baseline
There was a problem hiding this comment.
Pull Request Overview
Adds a comprehensive suite of draft “find all references” tests to the fourslash harness, covering TSX, runtime imports, JS exports, and many language constructs.
- Introduces TSX-specific findAllReferences test (
tsxFindAllReferences10_test.go). - Adds path-mapped tslib import reference tests and JS export rename tests.
- Generates dozens of new tests under
internal/fourslash/tests/gen/to exercise edge cases.
Reviewed Changes
Copilot reviewed 300 out of 595 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/fourslash/tests/gen/tsxFindAllReferences10_test.go | Add TSX component findAllReferences baseline test |
| internal/fourslash/tests/gen/tslibFindAllReferencesOnRuntimeImportWithPaths1_test.go | Add findAllReferences test for tslib imports with custom paths |
| internal/fourslash/tests/gen/renameJsExports03_test.go | Add JS export renaming reference test |
| internal/fourslash/tests/gen/renameJsExports02_test.go | Add second JS export rename test |
| internal/fourslash/tests/gen/remoteGetReferences_test.go | Add remote reference resolution tests |
| internal/fourslash/tests/gen/referencesToStringLiteralValue_test.go | Add string-literal reference tests |
| ... | Many additional generated tests covering properties, keywords, merges, modules, enums, JSX, JSDoc, and more |
iisaduan
requested review from
jakebailey,
sheetalkamat,
gabritto and
navya9singh
gabritto
requested changes
Jul 4, 2025
testdata/baselines/reference/fourslash/findAllRef/AmbientShorthandFindAllRefs.baseline.jsonc
Show resolved
Hide resolved
iisaduan
changed the title
VerifyBaselinefindAllReferences
…o fourslash-baseline
gabritto
approved these changes
Jul 8, 2025
gabritto
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports most of the baselining for fourslash (the functions that format FS content with range and location markers). There are features I did not port because they were not used in the baselines that I was porting/the functions I know that are planned on be ported pretty directly. I'm leaving those features unimplemented for now in case they are used differently/no longer used
Also adds
VerifyBaselineFindAllReferencesas an example of how to use the new baseline. These tests aren't being run against the submodule yet, they are just a standard "has the baseline changed" test. Not sure if we will eventually make these run against the submodule, since in corsa we currently only compute the locations of references so most of the stuff that is in the strada baseline (the json structures) is no longer computed. There are also some known bugs in what's currently implemented in FAR (see #1342)