Allow duplicate names in package.json parsing #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package.json parser to allow duplicate JSON names when used in package.json files.
- Modified the JSON unmarshal call in the parser to enable duplicate names.
- Added a test case to verify that duplicate keys in package.json do not result in errors.
- Introduced a helper function in expected.go to facilitate constructing expected output.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/packagejson/packagejson_test.go | Added a test case to validate the parsing of duplicate JSON keys |
| internal/packagejson/packagejson.go | Updated the JSON unmarshal call to allow duplicate names |
| internal/packagejson/expected.go | Added the ExpectedOf helper function for cleaner expected value creation |
andrewbranch
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new jsonv2 package explicitly disallows duplicate JSON names (see https://github.com/go-json-experiment/json/blob/1a886bd29d1ba88a537a14c2a85b9da9e1f9609e/v1/diff_test.go#L812), but JS doesn't care. Disable this check when parsing package.json.
Fixes #1316