Skip to content

Port TypeScript PR #62844: Gate #/ subpath imports on NodeNext and Bundler #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 5 commits into from
Dec 11, 2025
Merged

Port TypeScript PR #62844: Gate #/ subpath imports on NodeNext and Bundler #2330

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
232fd52
Initial plan
Copilot Dec 10, 2025
66afc4b
Port TypeScript PR #62844: Gate #/ subpath imports on NodeNext and Bu…
Copilot Dec 10, 2025
8ea9f24
Fix bit position for ImportsPatternRoot and add documentation
Copilot Dec 10, 2025
5e1ca7f
Remove unneeded compat-preserving bit slots
RyanCavanaugh Dec 10, 2025
400b4d7
Add compiler test cases for #/ subpath imports
Copilot Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/module/resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ func (r *resolutionState) loadModuleFromSelfNameReference() *resolved {
}

func (r *resolutionState) loadModuleFromImports() *resolved {
if r.name == "#" || strings.HasPrefix(r.name, "#/") {
if r.name == "#" || (strings.HasPrefix(r.name, "#/") && (r.features&NodeResolutionFeaturesImportsPatternRoot) == 0) {
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change enables #/ root wildcard imports for NodeNext and Bundler modes but lacks test coverage. According to the project guidelines, at least one minimal test case should be added to verify the new behavior works correctly in each mode (Node16 rejects, NodeNext/Bundler accepts). Consider adding a test in testdata/tests/cases/compiler/ that demonstrates:

  1. #/ pattern being rejected in Node16 mode
  2. #/ pattern being accepted in NodeNext mode
  3. #/ pattern being accepted in Bundler mode

The test should include a package.json with an imports field like "#/*": "./src/*" to match the example from the PR description.

Copilot uses AI. Check for mistakes.
if r.tracer != nil {
r.tracer.write(diagnostics.Invalid_import_specifier_0_has_no_possible_resolutions, r.name)
}
Expand Down
9 changes: 7 additions & 2 deletions internal/module/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,17 @@ const (
NodeResolutionFeaturesSelfName
NodeResolutionFeaturesExports
NodeResolutionFeaturesExportsPatternTrailers
_ // bit 4 is unused
_ // bit 5 is reserved for EsmMode (stored separately as a boolean field)
// allowing `#/` root imports in package.json imports field
// not supported until mass adoption - https://github.com/nodejs/node/pull/60864
NodeResolutionFeaturesImportsPatternRoot

NodeResolutionFeaturesNone NodeResolutionFeatures = 0
NodeResolutionFeaturesAll = NodeResolutionFeaturesImports | NodeResolutionFeaturesSelfName | NodeResolutionFeaturesExports | NodeResolutionFeaturesExportsPatternTrailers
NodeResolutionFeaturesAll = NodeResolutionFeaturesImports | NodeResolutionFeaturesSelfName | NodeResolutionFeaturesExports | NodeResolutionFeaturesExportsPatternTrailers | NodeResolutionFeaturesImportsPatternRoot
NodeResolutionFeaturesNode16Default = NodeResolutionFeaturesImports | NodeResolutionFeaturesSelfName | NodeResolutionFeaturesExports | NodeResolutionFeaturesExportsPatternTrailers
NodeResolutionFeaturesNodeNextDefault = NodeResolutionFeaturesAll
NodeResolutionFeaturesBundlerDefault = NodeResolutionFeaturesImports | NodeResolutionFeaturesSelfName | NodeResolutionFeaturesExports | NodeResolutionFeaturesExportsPatternTrailers
NodeResolutionFeaturesBundlerDefault = NodeResolutionFeaturesImports | NodeResolutionFeaturesSelfName | NodeResolutionFeaturesExports | NodeResolutionFeaturesExportsPatternTrailers | NodeResolutionFeaturesImportsPatternRoot
)

type PackageId struct {
Expand Down