Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add chronus version managing #4676

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

iscai-msft
Copy link
Member

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Oct 10, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 10, 2024

All changed packages have been documented.

  • @typespec/http-client-python
Show changes

@typespec/http-client-python - internal ✏️

add chronus to do version management

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@tadelesh
Copy link
Member

wait for upgrade to 0.61: #4692, then the ci should be green.

@iscai-msft
Copy link
Member Author

@timotheeguerin do you have a rough eta for when we can merge chronus version managing?

@@ -55,13 +55,17 @@ versionPolicies:
- "@typespec/sse"
- "@typespec/streams"
- "@typespec/xml"
- name: python-client
type: independent
step: patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
step: patch

step is for lockStep only

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the previous policy, it has type: lockstep and step: minor so I'm kind of confused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with step: patch instead of step: minor since I don't want to only officially release minor versions, but let me know if my understanding here isn't right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use lockStep policy it means all package in the policy will always increase by the given step. For independant it will just respect the change description(if you do major, minor, patch,etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:python Issue for the Python client emitter: @typespec/http-client-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants